From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Can I submit simple patches like this to the primary ML?
Date: Thu, 29 Jan 2015 06:19:12 -0800 [thread overview]
Message-ID: <20150129141912.GA8442@kroah.com> (raw)
In-Reply-To: <CALD9WKwHJVR+NNxB-CceEPZ2hH+H=CKPrYtWzYjZz1AwL8Fa_w@mail.gmail.com>
On Thu, Jan 29, 2015 at 09:27:48AM -0200, Vin?cius Tinti wrote:
> On Thu, Jan 29, 2015 at 3:07 AM, Greg KH <greg@kroah.com> wrote:
> >> In fact it causes a warning on Clang which complains that:
> >>
> >> arch/x86/tools/relocs.c:977:6: warning: variable 'do_reloc' is used
> >> uninitialized whenever 'if' condition is false
> >> [-Wsometimes-uninitialized]
> >
> > I suggest you file a bug with clang, gcc doesn't have this problem at
> > all as obviously, if you look at the code, that variable can never be
> > used uninitialized.
>
> I can simply turn down this kind of warning.
Or you can send a bug report to the clang developers so they can fix it,
which would be best in the end, right?
> >> I think there is not a problem on the current code but to avoid
> >> further problems I believe it is worth to initialize this function
> >> with NULL.
> >> What do you think?
> >
> > Don't paper over bugs in the compiler with kernel code changes for no
> > good reason :)
>
> Agreed. But whenever I find a warning in GCC during the build what
> should I do with it?
Depends on the specific warning, and what type of fix it requires. If
you do see them, and you are running with the latest version of gcc, and
the warning is for a problem that is real (hint, this problem was not
real as the code showed), then yes, of course submit a patch for it.
> Can I simply send it to the main ml?
Use the scripts/get_maintainer.pl tool on your patch to determine who to
send it to and what mailing lists to copy.
Hope this helps,
greg k-h
prev parent reply other threads:[~2015-01-29 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 3:48 Can I submit simple patches like this to the primary ML? Vinícius Tinti
2015-01-29 4:08 ` Greg KH
2015-01-29 4:16 ` Vinícius Tinti
2015-01-29 5:07 ` Greg KH
2015-01-29 11:27 ` Vinícius Tinti
2015-01-29 11:39 ` Peter Senna Tschudin
2015-01-29 14:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129141912.GA8442@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).