From mboxrd@z Thu Jan 1 00:00:00 1970 From: der.herr@hofr.at (Nicholas Mc Guire) Date: Fri, 13 Mar 2015 13:43:32 +0100 Subject: CHECK: Alignment should match open parenthesis In-Reply-To: <609013997.1677493.1426248436227.JavaMail.yahoo@mail.yahoo.com> References: <609013997.1677493.1426248436227.JavaMail.yahoo@mail.yahoo.com> Message-ID: <20150313124332.GA22044@opentech.at> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On Fri, 13 Mar 2015, palik imre wrote: > Sorry for the silly question, but I have some issues with this checkpatch.pl warning. > > I mean Documentation/CodingStyle says: > > Outside of comments, documentation and except in Kconfig, spaces are never > used for indentation, and the above example is deliberately broken. > > But checkpatch.pl claims I should align to open parentheses. These two things seem to be contradictory to me. Could somebody clarify this? > leading tabs *followed* by spaces to align parameters to a function are fine but for basic block indentation you never use spaces. so func(param1, param2); would be allowed but not if (something) { if(something else) { HTH thx! hofrat