kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: der.herr@hofr.at (Nicholas Mc Guire)
To: kernelnewbies@lists.kernelnewbies.org
Subject: CHECK: Alignment should match open parenthesis
Date: Fri, 13 Mar 2015 14:28:02 +0100	[thread overview]
Message-ID: <20150313132802.GA13910@opentech.at> (raw)
In-Reply-To: <1158748566.6782126.1426252169494.JavaMail.yahoo@mail.yahoo.com>

On Fri, 13 Mar 2015, palik imre wrote:

> On Friday, 13 March 2015, 13:43, Nicholas Mc Guire <der.herr@hofr.at> wrote:
> > On Fri, 13 Mar 2015, palik imre wrote:
> > 
> > 
> > > Sorry for the silly question, but I have some issues with this checkpatch.pl warning.
> > >
> > > I mean Documentation/CodingStyle says:
> > >
> > > Outside of comments, documentation and except in Kconfig, spaces are never
> > > used for indentation, and the above example is deliberately broken.
> > >
> > > But checkpatch.pl claims I should align to open parentheses.  These two things seem to be contradictory to me.  Could somebody clarify this?
> > 
> > >
> > leading tabs *followed* by spaces to align parameters to a function are fine
> 
> The emacs settings in Documentation/CodingStyle seem to contradict to you,
> as it is set up to use c-lineup-arglist-tabs-only
>
The problem is that CodingStyle does not explicitly address
parameter alignment for functions that do not fit on a single line
but checkpatch.pl does

you can try it out - if you align to the opening braces with spaces
with preceding TABs it will not fuss and this is also common practice.

thx!
hofrat

  reply	other threads:[~2015-03-13 13:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 12:07 CHECK: Alignment should match open parenthesis palik imre
2015-03-13 12:43 ` Nicholas Mc Guire
2015-03-13 13:09   ` palik imre
2015-03-13 13:28     ` Nicholas Mc Guire [this message]
2015-03-13 13:47       ` Nicholas Mc Guire
2015-03-13 14:35         ` Daniel Baluta
2015-03-13 14:46           ` Greg KH
2015-03-13 15:33           ` Nicholas Mc Guire
2015-03-13 16:15             ` Daniel Baluta
2015-03-13 16:46             ` Jeff Haran
2015-03-13 16:58               ` Nicholas Mc Guire
2015-03-13 17:18                 ` Jeff Haran
2015-03-13 17:31                   ` Nicholas Mc Guire
2015-03-13 18:05                     ` Jeff Haran
2015-03-13 18:57                       ` Nicholas Mc Guire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150313132802.GA13910@opentech.at \
    --to=der.herr@hofr.at \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).