From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Checkpatch.pl warning
Date: Sat, 8 Aug 2015 11:42:57 -0700 [thread overview]
Message-ID: <20150808184257.GA13850@kroah.com> (raw)
In-Reply-To: <CAO393ACx7p6XcpCfs1r-ncuORow-ajzohBge5Ni09F9kDHyqqg@mail.gmail.com>
On Sat, Aug 08, 2015 at 11:19:43PM +0530, Shraddha Barke wrote:
> I have come across the following checkpatch.pl warning a number of times:
>
> WARNING: Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp
> ()
>
> What exactly does it mean?
> What is the fix for this warning?
> Any help or links to appropriate Documentation will be good.
If you don't know what this is, or how network drivers work, I strongly
recommend not worrying about this at all, it's a tricky thing to get
right, and something that I need a _lot_ of proof before I ever accept
patches that do this.
I suggest working on something else.
best of luck,
greg k-h
next prev parent reply other threads:[~2015-08-08 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 17:49 Checkpatch.pl warning Shraddha Barke
2015-08-08 18:42 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-30 13:04 Shubham Singh
2018-09-30 22:57 ` valdis.kletnieks at vt.edu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150808184257.GA13850@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).