From mboxrd@z Thu Jan 1 00:00:00 1970 From: greg@kroah.com (Greg KH) Date: Fri, 9 Oct 2015 12:20:48 -0700 Subject: I have a large patch in the 2000 lines. What to do? In-Reply-To: References: <56180B3F.9040208@gmail.com> Message-ID: <20151009192048.GA16217@kroah.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On Fri, Oct 09, 2015 at 12:12:44PM -0700, Anish Kumar wrote: > > > > On Oct 9, 2015, at 11:45 AM, Ivan Safonov wrote: > > > > Hi! > > > > I have a large patch in the 2000 lines, which replaces the macro BITn to > > BIT(n) in multiple files. > > I will recommend sending RFC patch first and > Get the community comments. No, we just ignore RFC patches, we have too many "real" patches to deal with. > If they like your patch then divide the patch based on logic rather than lines of codes. > > Is it worth to split this patch into several parts? Yes. > > Is it sufficient to place the changes in each file in a separate part of > > patchset? Make it one-patch-per-driver. But note, cleanup patches like this are usually ignored by most subsystems, be aware that this type of thing is only usually accepted in the drivers/staging/ portion of the kernel. good luck! greg k-h