kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: navych@126.com (Navy Cheng)
To: kernelnewbies@lists.kernelnewbies.org
Subject: What's wrong with my patch?
Date: Tue, 8 Mar 2016 13:31:05 +0800	[thread overview]
Message-ID: <20160308053105.GA12422@debian> (raw)

Hi,
I have sent a patch on 29 Feb, but no reply. I want to know what's wrong
with my patch so that I can improve it and myself. my patch is like this:

> Date: Mon, 29 Feb 2016 14:41:34 +0800
> From: Navy Cheng <navych@126.com>
> To: Greg Kroah-Hartman <greg@kroah.com>
> Cc: Lidza Louina <lidza.louina@gmail.com>, kernelnewbies <kernelnewbies@kernelnewbies.org>
> Subject: [PATCH] staging: dgnc: Remove useless and deadly judgment
> User-Agent: Mutt/1.5.23 (2014-03-12)
> 
> pci_unregister_driver() should be used once dgnc module exit. It has
> nothing to do with dgnc_NumBoards. Remove the judgment of dgnc_NumBoards to
> avoid pci_unregister_driver() is not used when dgnc_NumBoards is 0.
> 
> Signed-off-by: Navy Cheng <navych@126.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index fc6d298..20b0c3b 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -156,8 +156,7 @@ static void dgnc_cleanup_module(void)
> 
>         dgnc_tty_post_uninit();
> 
> -       if (dgnc_NumBoards)
> -               pci_unregister_driver(&dgnc_driver);
> +       pci_unregister_driver(&dgnc_driver);
>  }
> 
>  /*
 
Thank you :)

             reply	other threads:[~2016-03-08  5:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  5:31 Navy Cheng [this message]
2016-03-08  8:14 ` What's wrong with my patch? Laurent Navet
2016-03-09  6:24   ` Navy Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160308053105.GA12422@debian \
    --to=navych@126.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).