What's wrong with my patch?

* What's wrong with my patch?
@ 2016-03-08  5:31 Navy Cheng
  2016-03-08  8:14 ` Laurent Navet
  0 siblings, 1 reply; 3+ messages in thread
From: Navy Cheng @ 2016-03-08  5:31 UTC (permalink / raw)
  To: kernelnewbies

Hi,
I have sent a patch on 29 Feb, but no reply. I want to know what's wrong
with my patch so that I can improve it and myself. my patch is like this:

> Date: Mon, 29 Feb 2016 14:41:34 +0800
> From: Navy Cheng <navych@126.com>
> To: Greg Kroah-Hartman <greg@kroah.com>
> Cc: Lidza Louina <lidza.louina@gmail.com>, kernelnewbies <kernelnewbies@kernelnewbies.org>
> Subject: [PATCH] staging: dgnc: Remove useless and deadly judgment
> User-Agent: Mutt/1.5.23 (2014-03-12)
> 
> pci_unregister_driver() should be used once dgnc module exit. It has
> nothing to do with dgnc_NumBoards. Remove the judgment of dgnc_NumBoards to
> avoid pci_unregister_driver() is not used when dgnc_NumBoards is 0.
> 
> Signed-off-by: Navy Cheng <navych@126.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index fc6d298..20b0c3b 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -156,8 +156,7 @@ static void dgnc_cleanup_module(void)
> 
>         dgnc_tty_post_uninit();
> 
> -       if (dgnc_NumBoards)
> -               pci_unregister_driver(&dgnc_driver);
> +       pci_unregister_driver(&dgnc_driver);
>  }
> 
>  /*

Thank you :)

^ permalink raw reply	[flat|nested] 3+ messages in thread