From mboxrd@z Thu Jan  1 00:00:00 1970
From: navych@126.com (Navy Cheng)
Date: Wed, 9 Mar 2016 14:24:17 +0800
Subject: What's wrong with my patch?
In-Reply-To: <CAH7P7NgH722mwZ=6iXSO+Hr0G5+GCg44v1TEiDmZknyhJZWWnw@mail.gmail.com>
References: <20160308053105.GA12422@debian>
	<CAH7P7NgH722mwZ=6iXSO+Hr0G5+GCg44v1TEiDmZknyhJZWWnw@mail.gmail.com>
Message-ID: <20160309062416.GA32637@debian>
To: kernelnewbies@lists.kernelnewbies.org
List-Id: kernelnewbies.lists.kernelnewbies.org

Thank you for your reply :)

>  29 Feb is only one week old,
> your patch is in queue, just wait.
> 
> 2016-03-08 6:31 UTC+01:00, Navy Cheng <navych@126.com>:
> > Hi,
> > I have sent a patch on 29 Feb, but no reply. I want to know what's wrong
> > with my patch so that I can improve it and myself. my patch is like this:
> >
> >> Date: Mon, 29 Feb 2016 14:41:34 +0800
> >> From: Navy Cheng <navych@126.com>
> >> To: Greg Kroah-Hartman <greg@kroah.com>
> >> Cc: Lidza Louina <lidza.louina@gmail.com>, kernelnewbies
> >> <kernelnewbies@kernelnewbies.org>
> >> Subject: [PATCH] staging: dgnc: Remove useless and deadly judgment
> >> User-Agent: Mutt/1.5.23 (2014-03-12)
> >>
> >> pci_unregister_driver() should be used once dgnc module exit. It has
> >> nothing to do with dgnc_NumBoards. Remove the judgment of dgnc_NumBoards
> >> to
> >> avoid pci_unregister_driver() is not used when dgnc_NumBoards is 0.
> >>
> >> Signed-off-by: Navy Cheng <navych@126.com>
> >> ---
> >>  drivers/staging/dgnc/dgnc_driver.c | 3 +--
> >>   1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/dgnc/dgnc_driver.c
> >> b/drivers/staging/dgnc/dgnc_driver.c
> >> index fc6d298..20b0c3b 100644
> >> --- a/drivers/staging/dgnc/dgnc_driver.c
> >> +++ b/drivers/staging/dgnc/dgnc_driver.c
> >> @@ -156,8 +156,7 @@ static void dgnc_cleanup_module(void)
> >>
> >>         dgnc_tty_post_uninit();
> >>
> >> -       if (dgnc_NumBoards)
> >> -               pci_unregister_driver(&dgnc_driver);
> >> +       pci_unregister_driver(&dgnc_driver);
> >>  }
> >>
> >>  /*
> >
> > Thank you :)
> >
> >
> > _______________________________________________
> > Kernelnewbies mailing list
> > Kernelnewbies at kernelnewbies.org
> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
> >
> 
> 
> -- 
> ? On ne r?sout pas un probl?me avec les modes de pens?e qui l?ont engendr?. ?
> ? You cannot solve current problems with current thinking. Current
> problems are the result of current thinking ?
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies