Submitting patches to non-staging

Submitting patches to non-staging

[Pratyush Patel]

Hello all,

I am new to Linux kernel development and am hoping to contribute to
the Linux community. I recently read Robert Love's LKD book, and have
gone through some of the documents and patch submitting guidelines on
kernelnewbies.org.

I will be pursuing my undergraduate thesis research in the field of
real-time (operating) systems and as such, I expect to be closely
involved with the timer and interrupt subsystems in Linux (as well as
other areas, but to a lesser degree). I am also hoping to work with
the hrtimer subsystem, and while going through the latest code
(4.5-rc6) of the same, I found a very minor code-level change that
could be incorporated (redundant #ifdef). Would such a change in a
core kernel file be acceptable coming from a beginner? Or should I aim
for the staging drivers first?

I very much look forward to contributing my first patch!

Thanks,
Pratyush

Submitting patches to non-staging

[Sudip Mukherjee]

On Tue, Mar 1, 2016 at 9:16 PM, Pratyush Patel
<pratyushpatel.1995@gmail.com> wrote:
> Hello all,
>
> I am new to Linux kernel development and am hoping to contribute to
> the Linux community. I recently read Robert Love's LKD book, and have
> gone through some of the documents and patch submitting guidelines on
> kernelnewbies.org.
>
> I will be pursuing my undergraduate thesis research in the field of
> real-time (operating) systems and as such, I expect to be closely
> involved with the timer and interrupt subsystems in Linux (as well as
> other areas, but to a lesser degree). I am also hoping to work with
> the hrtimer subsystem, and while going through the latest code
> (4.5-rc6) of the same, I found a very minor code-level change that
> could be incorporated (redundant #ifdef). Would such a change in a
> core kernel file be acceptable coming from a beginner? Or should I aim
> for the staging drivers first?

If it is valid change it will be accepted. But better to start with staging,
learn and experience the process of patch submission then go to your
preferred subsystem.

regards
sudip

Submitting patches to non-staging

[Pratyush Patel]

On Tue, Mar 1, 2016 at 9:24 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Tue, Mar 1, 2016 at 9:16 PM, Pratyush Patel
> <pratyushpatel.1995@gmail.com> wrote:
>> Hello all,
>>
>> I am new to Linux kernel development and am hoping to contribute to
>> the Linux community. I recently read Robert Love's LKD book, and have
>> gone through some of the documents and patch submitting guidelines on
>> kernelnewbies.org.
>>
>> I will be pursuing my undergraduate thesis research in the field of
>> real-time (operating) systems and as such, I expect to be closely
>> involved with the timer and interrupt subsystems in Linux (as well as
>> other areas, but to a lesser degree). I am also hoping to work with
>> the hrtimer subsystem, and while going through the latest code
>> (4.5-rc6) of the same, I found a very minor code-level change that
>> could be incorporated (redundant #ifdef). Would such a change in a
>> core kernel file be acceptable coming from a beginner? Or should I aim
>> for the staging drivers first?
>
> If it is valid change it will be accepted. But better to start with staging,
> learn and experience the process of patch submission then go to your
> preferred subsystem.
>
> regards
> sudip

Thanks for the advice. I submitted my first patch in the hrtimer
subsystem, but will prefer staging area for my future (new) patches.

Submitting patches to non-staging

[Christoph Lameter]

On Tue, 1 Mar 2016, Pratyush Patel wrote:

> I will be pursuing my undergraduate thesis research in the field of
> real-time (operating) systems and as such, I expect to be closely
> involved with the timer and interrupt subsystems in Linux (as well as
> other areas, but to a lesser degree). I am also hoping to work with
> the hrtimer subsystem, and while going through the latest code
> (4.5-rc6) of the same, I found a very minor code-level change that
> could be incorporated (redundant #ifdef). Would such a change in a
> core kernel file be acceptable coming from a beginner? Or should I aim
> for the staging drivers first?

Dont worry about staging. There is no staing for interrupts and timers. Go
direct and post to the relevant maintainers and lkml

> I very much look forward to contributing my first patch!

love to see it.

Submitting patches to non-staging

[Pratyush Patel]

On Thu, Mar 3, 2016 at 1:15 AM, Christoph Lameter <cl@linux.com> wrote:
> On Tue, 1 Mar 2016, Pratyush Patel wrote:
>
>> I will be pursuing my undergraduate thesis research in the field of
>> real-time (operating) systems and as such, I expect to be closely
>> involved with the timer and interrupt subsystems in Linux (as well as
>> other areas, but to a lesser degree). I am also hoping to work with
>> the hrtimer subsystem, and while going through the latest code
>> (4.5-rc6) of the same, I found a very minor code-level change that
>> could be incorporated (redundant #ifdef). Would such a change in a
>> core kernel file be acceptable coming from a beginner? Or should I aim
>> for the staging drivers first?
>
> Dont worry about staging. There is no staing for interrupts and timers. Go
> direct and post to the relevant maintainers and lkml
>
>> I very much look forward to contributing my first patch!
>
> love to see it.
>

Here's the archive link: http://comments.gmane.org/gmane.linux.kernel/2165466

Please do let me know in case I did something wrongly.

Awaiting for it to be accepted!

Submitting patches to non-staging

[Anuz Pratap Singh Tomar]

On Thu, Mar 3, 2016 at 1:50 AM, Pratyush Patel <pratyushpatel.1995@gmail.com
> wrote:

> On Thu, Mar 3, 2016 at 1:15 AM, Christoph Lameter <cl@linux.com> wrote:
> > On Tue, 1 Mar 2016, Pratyush Patel wrote:
> >
> >> I will be pursuing my undergraduate thesis research in the field of
> >> real-time (operating) systems and as such, I expect to be closely
> >> involved with the timer and interrupt subsystems in Linux (as well as
> >> other areas, but to a lesser degree). I am also hoping to work with
> >> the hrtimer subsystem, and while going through the latest code
> >> (4.5-rc6) of the same, I found a very minor code-level change that
> >> could be incorporated (redundant #ifdef). Would such a change in a
> >> core kernel file be acceptable coming from a beginner? Or should I aim
> >> for the staging drivers first?
> >
> > Dont worry about staging. There is no staing for interrupts and timers.
> Go
> > direct and post to the relevant maintainers and lkml
> >
> >> I very much look forward to contributing my first patch!
> >
> > love to see it.
> >
>
> Here's the archive link:
> http://comments.gmane.org/gmane.linux.kernel/2165466
>
> Please do let me know in case I did something wrongly.
>
> Awaiting for it to be accepted!
>
> Single line changes like that can be sent to Janitors mailing list.


> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>



-- 
Thank you
Warm Regards
Anuz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20160304/87215efc/attachment.html 

Submitting patches to non-staging

[Pratyush Patel]

On Fri, Mar 4, 2016 at 3:20 PM, Anuz Pratap Singh Tomar
<chambilkethakur@gmail.com> wrote:
>
>
> On Thu, Mar 3, 2016 at 1:50 AM, Pratyush Patel
> <pratyushpatel.1995@gmail.com> wrote:
>>
>> On Thu, Mar 3, 2016 at 1:15 AM, Christoph Lameter <cl@linux.com> wrote:
>> > On Tue, 1 Mar 2016, Pratyush Patel wrote:
>> >
>> >> I will be pursuing my undergraduate thesis research in the field of
>> >> real-time (operating) systems and as such, I expect to be closely
>> >> involved with the timer and interrupt subsystems in Linux (as well as
>> >> other areas, but to a lesser degree). I am also hoping to work with
>> >> the hrtimer subsystem, and while going through the latest code
>> >> (4.5-rc6) of the same, I found a very minor code-level change that
>> >> could be incorporated (redundant #ifdef). Would such a change in a
>> >> core kernel file be acceptable coming from a beginner? Or should I aim
>> >> for the staging drivers first?
>> >
>> > Dont worry about staging. There is no staing for interrupts and timers.
>> > Go
>> > direct and post to the relevant maintainers and lkml
>> >
>> >> I very much look forward to contributing my first patch!
>> >
>> > love to see it.
>> >
>>
>> Here's the archive link:
>> http://comments.gmane.org/gmane.linux.kernel/2165466
>>
>> Please do let me know in case I did something wrongly.
>>
>> Awaiting for it to be accepted!
>>
> Single line changes like that can be sent to Janitors mailing list.
>

Yes, I sent it to the maintainer (Thomas Gleixner), linux-kernel, and
the kernel-janitors mailing lists.

Submitting patches to non-staging

[Pratyush Patel]

On Fri, Mar 4, 2016 at 12:22 PM, Vishwas Srivastava
<vishu.kernel@gmail.com> wrote:
>
> It seems to be a valid change and should be accepted in the kernel.
>
>     You may probably change the commit message something like..
>    " removing nested macro definition (CONFIG_SMP)" if you want.
>    good luck
> -- Vishwas

That's good to hear, thanks for reviewing.

Is there a way to change the commit message given that I already
submitted the patch email (although it has not yet been accepted)?

-Pratyush

Submitting patches to non-staging

[Nahim `Naam` El Atmani]

Hi,

On Fri, 04 Mar 2016 21:52:53 +0530, Pratyush Patel wrote:
> Is there a way to change the commit message given that I already
> submitted the patch email (although it has not yet been accepted)?

Just reply to the thread you actually opened on the mailing list with your new
patch so that maintainers only have to apply it without modifications. Don't
forget to modify patch version accordingly etc.

All the best,

-- 
Nahim `Naam` El Atmani <naam@lse.epita.fr>
If less(1) is more than more(1), most(1) is more than less(1).