From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: query regarding emxx_udc
Date: Wed, 8 Feb 2017 08:26:15 +0100 [thread overview]
Message-ID: <20170208072615.GA4345@kroah.com> (raw)
In-Reply-To: <CAJoBqat0ZnXPh3mvPOue4PUK-uk83nDsyVbHufFkuX=qbQKnnw@mail.gmail.com>
On Wed, Feb 08, 2017 at 12:46:58PM +0530, Deeksha varshney wrote:
> In the file file drivers/staging /emxx_udc/emxx_udc.c every EPn_ type variable
> should be modified in seperate patches ?
> like EPn_BUF_TYPE should be modified as? EPN_BUF_TYPE in one patch
> and EPn_MPKT as EPN_MPKT in another patch.?
Step back and think about what you are changing here. Why is the
current naming scheme not correct? It properly describes what the
define is, and what it is for. I would strongly recommend just leaving
it as-is, there is nothing wrong with it.
Remember, checkpatch.pl is a _hint_, you always have to use your brain
when reading the output of it.
hope this helps,
greg k-h
next prev parent reply other threads:[~2017-02-08 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 7:16 query regarding emxx_udc Deeksha varshney
2017-02-08 7:26 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-03 8:04 Query " Deeksha varshney
2017-02-03 11:17 ` Amit Kumar
2017-02-03 12:00 ` Greg KH
2017-02-04 4:27 ` Deeksha varshney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208072615.GA4345@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).