kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: me@tobin.cc (Tobin Harding)
To: kernelnewbies@lists.kernelnewbies.org
Subject: recovery from fail
Date: Mon, 13 Feb 2017 12:29:04 +1100	[thread overview]
Message-ID: <20170213012904.GA13476@eros> (raw)

I have made and epic fail and am asking for advice on how to proceed
to cause the least amount of upset.

I submitted a simple patch series to LKML. A reviewer made a
suggestion. I submitted v2 - without building it :(

kbuild test robot picked up that it doesn't compile. The problem is
that I now cannot get the second patch of the series to compile.

What is the correct protocol to follow?

I don't want to make any more noise than I already have but I also
don't want to ignore the reviewer by not implementing the suggested
changes.

Is it rude to reply to the original review email for further
discussion having already botched the patch?


Thanks in advance,
Tobin.

             reply	other threads:[~2017-02-13  1:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13  1:29 Tobin Harding [this message]
2017-02-13 23:10 ` recovery from fail Andrey Utkin
2017-02-14  6:43   ` valdis.kletnieks at vt.edu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170213012904.GA13476@eros \
    --to=me@tobin.cc \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).