From mboxrd@z Thu Jan 1 00:00:00 1970 From: greg@kroah.com (Greg KH) Date: Tue, 21 Feb 2017 08:02:47 +0100 Subject: kernel development process question, patch review In-Reply-To: <20170221013533.GA23212@eros> References: <20170221013533.GA23212@eros> Message-ID: <20170221070247.GA8499@kroah.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On Tue, Feb 21, 2017 at 12:35:33PM +1100, Tobin C. Harding wrote: > If a reviewer makes a suggestion and one intends on making the change > as suggested is it required (normal protocol) to reply stating that > the you understand their suggestion and intend on implementing it or > is this just noise. Should one simply re send the next version of the > patch? If you were a reviewer, which would you like to see happen if you took the time to review someone else's work? > Continuing on this theme, should one add a Suggested-by: tag in the > previous situation. Some where Documentation/process it states that no > tag except the CC tag should be added without the authority of the > person being named? Suggested-by: is usually for the whole idea of the patch itself, not for revisions within a patch. good luck! greg k-h