From: me@tobin.cc (Tobin C. Harding)
To: kernelnewbies@lists.kernelnewbies.org
Subject: patch protocol question
Date: Wed, 8 Mar 2017 14:56:05 +1100 [thread overview]
Message-ID: <20170308035605.GB13728@eros> (raw)
In-Reply-To: <CA+MoWDpVFN=XGF1oOKuDwFy+4Pwk+th_nh-rOQLpEpcURJ863g@mail.gmail.com>
On Wed, Mar 08, 2017 at 12:12:50AM +0100, Peter Senna Tschudin wrote:
> On Tue, Mar 7, 2017 at 10:29 PM, Tobin C. Harding <me@tobin.cc> wrote:
> > I would like to know the correct protocol in order to make the
> > maintainers job as easy as possible please.
> >
> > Once a patch has been reviewed and the review makes good points that
> > mean the patch is invalid/unnecessary what is the protocol from then?
>
> I usually go for a beer when a patch I sent is not needed(two if my
> patch breaks something). If you agree that your patch is not needed,
> this is the end.
>
> > Assuming one replies to the reviewer with thanks and acknowledging
> > their points. Is it then protocol to state that you are not going to
> > pursue the patch further? How do maintainers know to not bother any
> > more with a patch?
>
> There is no universal rule that covers all cases, but in general if a
> maintainer states that a patch is not needed, this is the end. Unless
> someone(can be you) makes a point that clarifies the need for your
> patch. In the later case the discussion will make it clear what to do
> next.
>
> >
> > Similar question; if the last patch of a patch series is not needed
> > should one resend another version without the last patch or is there
> > an accepted protocol to signal this so that the maintainer only looks
> > at merging the initial patches in the series.
>
> It is easier for the maintainer to let his/her automation to take care
> of the entire series. So the extra work you are going to have to
> re-send will save the maintainer some work, so resend the series if
> one of the patches are not needed. Exception here is if the maintainer
> asks you to do differently.
Got it.
thanks,
Tobin.
prev parent reply other threads:[~2017-03-08 3:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 21:29 patch protocol question Tobin C. Harding
2017-03-07 23:12 ` Peter Senna Tschudin
2017-03-08 3:56 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308035605.GB13728@eros \
--to=me@tobin.cc \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).