From: me@tobin.cc (Tobin C. Harding)
To: kernelnewbies@lists.kernelnewbies.org
Subject: return codes
Date: Tue, 14 Mar 2017 13:03:07 +1100 [thread overview]
Message-ID: <20170314020307.GC25311@eros> (raw)
On investigating call sites for 'return' in drivers/staging/ks7010/
it can be seen that a number of functions us *custom* (positive)
integers to indicate error. Notwithstanding that they are positive, is
this ok for code in the kernel (i.e in order to get out of staging
does this need to be changed)? Functions in question have internal linkage
and the error code is used for debug messages.
Should these be
A) left alone
B) made negative
C) changed to use standard error codes (i.e -ENOMEM etc)
thanks,
Tobin.
next reply other threads:[~2017-03-14 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 2:03 Tobin C. Harding [this message]
2017-03-14 2:08 ` return codes Greg KH
2017-03-14 2:45 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314020307.GC25311@eros \
--to=me@tobin.cc \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).