From: me@tobin.cc (Tobin C. Harding)
To: kernelnewbies@lists.kernelnewbies.org
Subject: coccinelle
Date: Tue, 14 Mar 2017 22:00:18 +1100 [thread overview]
Message-ID: <20170314110018.GA15322@eros> (raw)
In-Reply-To: <20170314082608.GC24084@osadl.at>
On Tue, Mar 14, 2017 at 08:26:08AM +0000, Nicholas Mc Guire wrote:
> On Tue, Mar 14, 2017 at 06:21:06PM +1100, Tobin C. Harding wrote:
> > Attempting to do transform using Coccinelle
> >
> > if (foo != 0) {
> > ...
> >
> > ->
> >
> > if (foo) {
> > ...
> >
> > Coccinelle script attempt does not work
> >
> > @@ expression x; @@
> > (
> > - x != 0
> > + x
> > )
>
> I think you do not need the () here as you only are providing one semanntic patch
> the only thing that was missing is the virtual rule - so using this simple spatch
> file works for me
>
> <snip>
> virtual patch
>
> @tonull@
> expression x;
> @@
>
> - x != 0
> + x
> <snip>
>
> hofrat at debian01:~/git/linux-next$ spatch --sp-file x.cocci --dir kernel/ | more
> init_defs_builtins: /usr/local/lib/coccinelle/standard.h
> no inferred keywords
> HANDLING: kernel/sched/cpudeadline.c
> diff =
> HANDLING: kernel/sched/swait.c
> diff -u -p a/sched/cpudeadline.c b/sched/cpudeadline.c
> --- a/sched/cpudeadline.c
> +++ b/sched/cpudeadline.c
> @@ -80,7 +80,7 @@ static void cpudl_heapify_up(struct cpud
> int orig_cpu = cp->elements[idx].cpu;
> u64 orig_dl = cp->elements[idx].dl;
>
> - if (idx == 0)
> + if (!idx)
> return;
> ....
>
>
> >
> > `spatch --parse-cocci script.cocci` appears to pass. A similar script
> > worked correctly
> >
> > @@ expression x; @@
> > (
> > - x == 0
> > + !x
> > )
>
> likewise
>
> <snip>
> virtual patch
>
> @tontnull@
> expression x;
> @@
>
> - x == 0
> + !x
> <snip>
>
> Using: spatch --version
> spatch version 1.0.6-00033-g23cca0a compiled with OCaml version 4.0
> .0
> Flags passed to the configure script: [none]
> Python scripting support: yes
> Syntax of regular expresssions: PCRE
>
>
> >
> > I have read various papers and tutorials to no avail. I have tried
> > various other versions also with no success.
> >
> > Any pointers most appreciated.
> >
> first you might want to read through the myriads of examples that
> come with coccinelle in the kernel:
> scripts/coccinelle/*
> Documentation/dev-tools/coccinelle.rst
>
> as well as the documentation in coccinelle repository:
> URL: https://github.com/coccinelle/coccinelle
>
> And for specific technologies like semantic patches it is best to signeup
> to the coccinelle mailing list and send such questions to
> Cocci at systeme.lip6.fr
> archive at: https://systeme.lip6.fr/mailman/listinfo/cocci
>
> thx!
> hofrat
thanks Hofrat, awesome.
prev parent reply other threads:[~2017-03-14 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 7:21 coccinelle Tobin C. Harding
2017-03-14 7:52 ` coccinelle Peter Senna Tschudin
2017-03-14 11:01 ` coccinelle Tobin C. Harding
2017-03-14 8:26 ` coccinelle Nicholas Mc Guire
2017-03-14 11:00 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314110018.GA15322@eros \
--to=me@tobin.cc \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).