From: me@tobin.cc (Tobin C. Harding)
To: kernelnewbies@lists.kernelnewbies.org
Subject: My kernel patch was rejected with comments
Date: Wed, 22 Mar 2017 21:32:10 +1100 [thread overview]
Message-ID: <20170322103210.GA2570@eros> (raw)
In-Reply-To: <CAA2DH4uVtepcGYzNARSABWwpoogV8YVXxjGLYdeS+XJz4o7qTA@mail.gmail.com>
On Wed, Mar 22, 2017 at 12:24:47PM +0530, Prasant J wrote:
> Hi,
>
> I submitted a kernel patch and it was rejected with comments from
> maintainer. Is it important to reply with a new patch against
> maintainers response mail? Or it it ok if I send a new email with the
> updated patch?
You don't send the new patch as a reply. You may, if you wish, reply
to the maintainer (or reviewer) with some comments that you understand
and intend on implementing their suggestions (and thanks) or
disagreeing as it may be.
You then re-work your patch and submit it as normal using git
send-email. But you put v2 in the subject. You can use
git format-patch -X --subject-prefix='PATCH v2' --numbered --cover-letter
(where X is the number of commits to add to the series, assuming it is
a series).
In the cover letter add a section stating the changes since v1, for
example
v1 -> v2
- use foo() instead of bar()
If it is a single patch, you may wish to just edit the subject
manually. Make sure you put the version change information below the
--- line so it is not included if/when the patch gets merged.
Good luck,
Tobin.
>
>
> I have mutt and git send-mail setup but I can only send mail with
> those. How do I reply to a maintainers comment?
>
>
> I manually copied Message-ID from gmail web GUI and tried using it in
> "--in-reply-to" with git send email but when I saw the linux mailing
> list, it did weird things. It sent a blank reply to maintainers email
> and sent a new mail with my updated patch.
>
>
> Is there any tutorial on how can a I setup my workflow?
>
>
> Any inputs will be of great help here!
>
>
> Regards, Pj
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2017-03-22 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 6:54 My kernel patch was rejected with comments Prasant J
2017-03-22 10:32 ` Tobin C. Harding [this message]
2017-03-22 11:39 ` Prasant J
2017-03-22 12:20 ` Pranay Srivastava
2017-03-22 12:50 ` Ozgur Karatas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322103210.GA2570@eros \
--to=me@tobin.cc \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).