kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: My network device don't work
Date: Tue, 20 Jun 2017 22:12:34 +0800	[thread overview]
Message-ID: <20170620141234.GA2599@kroah.com> (raw)
In-Reply-To: <186270325-26e3212af6540c227a34d3cd3b5e0c56@pmq3v.m5r2.onet>

On Tue, Jun 20, 2017 at 02:32:31PM +0200, wiktoria.lewicka wrote:
> Hello.
> I write simple network device, but its don't work. Module is loading, loading, loading...
> Code:
> 
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/netdevice.h>
> #include <linux/string.h>
> #define DEV_NAME "chwdp"
> 
> struct net_device my_netdev;
> 
> int init_my_net_dev(struct net_device *dev);
> 
> struct net_device_ops nops = {
>   .ndo_init = init_my_net_dev,
>   //.ndo_uninit = uninit_my_net_dev,
> };
> 
> static int __init init_dev(void)
> {
>   //my_netdev.netdev_ops = &nops;
>   int result;
>   if((netdev_boot_setup_check(&my_netdev))){
>     printk(KERN_ERR "NETDEV: setup error");
>     return 0;

Why are you returning success if there was an error?

And always try to use proper kernel coding style when writing kernel
code if you expect/want someone else to read it :)

thanks,

greg k-h

  parent reply	other threads:[~2017-06-20 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20 12:32 My network device don't work wiktoria.lewicka
2017-06-20 13:31 ` Stan Drozd
2017-06-20 14:12 ` Greg KH [this message]
2017-06-20 23:35   ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620141234.GA2599@kroah.com \
    --to=greg@kroah.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).