From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Reviews on linux-kernel
Date: Tue, 26 Sep 2017 09:43:35 +0200 [thread overview]
Message-ID: <20170926074335.GA29961@kroah.com> (raw)
In-Reply-To: <f9794d17-7d46-1bc4-03ae-c26e4a54942a@boehmwalder.at>
On Tue, Sep 26, 2017 at 09:19:15AM +0200, Christoph B?hmwalder wrote:
> Hi all,
>
> Here's a question that the various "how to help" documents about the
> linux-kernel mailing list couldn't help me answer:
>
> Is anyone "allowed" to review patches on the mailing list?
Yes, please do so.
> Is it considered appropriate for any random person to review a change
> and approve/disapprove of it (given, of course, they have an
> understanding of what's going on in and around the patch), or is this
> right reserved for subsystem maintainers and other "known" people?
Anyone can do this.
> Let's say I saw a trivial patch on the linux-wireless mailing list,
> replacing a local function by a globally defined one (e.g. ARRAY_SIZE).
> If I know and understand what the patch does, is it appropriate for me
> to put an "Acked-by" or "Reviewed-by" under it, even if I'm technically
> not a part of this community?
There is no "technically" here, if you participate, you are part of the
community, don't think there is some sort of "gatekeeper" here at all.
Please, review away!
greg k-h
next prev parent reply other threads:[~2017-09-26 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 7:19 Reviews on linux-kernel Christoph Böhmwalder
2017-09-26 7:43 ` Greg KH [this message]
2017-09-26 7:58 ` Christoph Böhmwalder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926074335.GA29961@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).