From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: kernelnewbies@lists.kernelnewbies.org
Subject: git pull
Date: Tue, 14 Nov 2017 13:09:30 +0100 [thread overview]
Message-ID: <20171114120930.GA28122@kroah.com> (raw)
In-Reply-To: <CAPDyKFoThTrKcL4yj3pAhS5ivad_wUMjLBgSUu_KzeiOvU59RQ@mail.gmail.com>
On Tue, Nov 14, 2017 at 01:00:14PM +0100, Ulf Hansson wrote:
> [...]
>
> >
> > An example pull request of mine might look like:
> > Char/Misc patches for 4.15-rc1
> >
> > Here is the big char/misc patch set for the 4.15-rc1 merge
> > window. Contained in here is the normal set of new functions
> > added to all of these crazy drivers, as well as the following
> > brand new subsystems:
> > - time_travel_controller: Finally a set of drivers for
> > the latest time travel bus architecture that provides
> > i/o to the CPU before it asked for it, allowing
> > uninterrupted processing
> > - relativity_shifters: due to the affect that the
> > time_travel_controllers have on the overall system,
> > there was a need for a new set of relativity shifter
> > drivers to accommodate the newly formed black holes
> > that would threaten to suck CPUs into them. This
> > subsystem handles this in a way to successfully
> > neutralize the problems. There is a Kconfig option to
> > force these to be enabled when needed, so problems
> > should not occur.
> >
> > All of these patches have been successfully tested in the latest
> > linux-next releases, and the original problems that it found
> > have all been resolved (apologies to anyone living near Canberra
> > for the lack of the Kconfig options in the earlier versions of
> > the linux-next tree creations.)
> >
> > Signed-off-by: Your-name-here <your_email@domain>
> >
> >
> > The tag message format is just like a git commit id. One line at the
> > top for a "summary subject" and be sure to sign-off at the bottom.
>
> I don't add my s-o-b to signed tags for pull requests, but perhaps I should.
>
> However, I think most maintainers don't use it, and neither does it
> seems like Linus is preserving the tag when he does the pull.
The text of the tag is in the merge commit, but you are right, the
signed-off-by doesn't seem to be in the merge commit, I guess Linus's
workflow removes them. I know I keep them in there if present for pull
requests that people send to me.
thanks,
greg k-h
next prev parent reply other threads:[~2017-11-14 12:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 23:11 git pull Tobin C. Harding
2017-11-14 11:05 ` Greg Kroah-Hartman
2017-11-14 12:00 ` Ulf Hansson
2017-11-14 12:09 ` Greg Kroah-Hartman [this message]
2017-11-14 18:04 ` Linus Torvalds
2017-11-14 21:33 ` Tobin C. Harding
2017-11-14 21:46 ` Linus Torvalds
2017-11-15 10:51 ` Michael Ellerman
2017-11-16 20:36 ` Linus Torvalds
2017-11-14 21:42 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114120930.GA28122@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).