* My first patch - patch for adl_pci9118.c
@ 2017-11-18 12:07 Fabian Baumanis
2017-11-18 12:19 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Baumanis @ 2017-11-18 12:07 UTC (permalink / raw)
To: kernelnewbies
Hi there,
this morning i created my first patch for the Linux kernel.
It fixes a style issue which was reported by using checkpatch.pl on
drivers/staging/comedi/drivers/adl_pci9118.c
Although it's a very small patch, i hope this is useful.
My question now is: how can i submit the patch to the developers?
Best regards and have a nice weekend,
Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-adl-pci-9118-style.patch
Type: text/x-patch
Size: 154 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20171118/e9840f82/attachment.bin
^ permalink raw reply [flat|nested] 2+ messages in thread
* My first patch - patch for adl_pci9118.c
2017-11-18 12:07 My first patch - patch for adl_pci9118.c Fabian Baumanis
@ 2017-11-18 12:19 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-11-18 12:19 UTC (permalink / raw)
To: kernelnewbies
On Sat, Nov 18, 2017 at 01:07:30PM +0100, Fabian Baumanis wrote:
> Hi there,
>
> this morning i created my first patch for the Linux kernel.
> It fixes a style issue which was reported by using checkpatch.pl on
> drivers/staging/comedi/drivers/adl_pci9118.c
>
> Although it's a very small patch, i hope this is useful.
> My question now is: how can i submit the patch to the developers?
Please read Documentation/SubmittingPatches for the steps for how to
submit a patch.
> Best regards and have a nice weekend,
> Fabian
>
> 949,950c949
> < if ((cmd->flags & CMDF_WAKE_EOS) &&
> < (cmd->scan_end_arg == 1)) {
> ---
> > if cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1 {
Have you built the code with your change applied? Always do that first
:)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-18 12:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-18 12:07 My first patch - patch for adl_pci9118.c Fabian Baumanis
2017-11-18 12:19 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).