From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: submitting a patch for a stable tree
Date: Sun, 17 Dec 2017 21:23:45 +0100 [thread overview]
Message-ID: <20171217202345.GA23734@kroah.com> (raw)
In-Reply-To: <20171217192436.GA1621@botnar.kaiser.cx>
On Sun, Dec 17, 2017 at 08:24:36PM +0100, Martin Kaiser wrote:
> Dear all,
>
> I tried to submit a patch for 4.14 that was already accepted upstream
> and is in linux-next and the 4.15-rcs.
>
> To understand how this should be done, I looked at
> https://www.kernel.org/doc/html/v4.14/process/stable-kernel-rules.html
> and tried to follow Option 2. It looks like I didn't get it right.
>
>
> I started with a tree that contains the patch and ran
>
> git format-patch -1 <commit id>
>
> and then
>
> git send-email --to stable at verg.kernel.org \
> --cc <the original maintainer and reviewers> \
> --annotate <patch file>
>
> I added the upstream commit id above the original commit message and a
> tag line
>
> Cc: <stable@vger.kernel.org> # 4.14.x
>
> to the patch and sent it out.
You did? Was this on December 12:
Subject: [PATCH] mfd: fsl-imx25: Clean up irq settings during removal
?
If so, I totally missed it (just now dug in my archives to find it.)
> Is there anything that's wrong or missing? Is there a mailing list
> archive for stable at vger.kernel.org where I can have a look at correct
> submissions and check that my submission made it to the list?
There is an archive, yes, I think vger lists it.
As for what to do next time, I ignored this as I didn't know what to do
with it. For some reason I thought it was just a "normal" patch being
sent to the subsystem, sorry.
Next time put below the --- line something like "Can you queue this up
for 4.14?"
Or even a simpler email would be:
Can you please include git commit id 18f773937968 ("mfd:
fsl-imx25: Clean up irq settings during removal") in the 4.14
stable tree? I forgot to tag it when I submitted it to the mfd
subsystem.
And I can take it from there.
Care to try that?
And also, you can just email the stable list in response to your
original message saying "Just curious as to the state of this." I do
get a ton of email, and sometimes things fall through the cracks, like
this time. Being reminded after a week or two is not a problem, if you
don't get a response, it's usually required :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-17 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 19:24 submitting a patch for a stable tree Martin Kaiser
2017-12-17 20:23 ` Greg KH [this message]
2017-12-18 9:38 ` Greg KH
2017-12-18 13:04 ` Martin Kaiser
2017-12-18 12:54 ` Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171217202345.GA23734@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).