submitting a patch for a stable tree

submitting a patch for a stable tree

[Martin Kaiser]

Dear all,

I tried to submit a patch for 4.14 that was already accepted upstream
and is in linux-next and the 4.15-rcs.

To understand how this should be done, I looked at
https://www.kernel.org/doc/html/v4.14/process/stable-kernel-rules.html
and tried to follow Option 2. It looks like I didn't get it right.


I started with a tree that contains the patch and ran

git format-patch -1 <commit id>

and then

git send-email --to stable at verg.kernel.org \
   --cc <the original maintainer and reviewers> \
   --annotate <patch file>

I added the upstream commit id above the original commit message and a
tag line

Cc: <stable@vger.kernel.org> # 4.14.x

to the patch and sent it out.


Is there anything that's wrong or missing? Is there a mailing list
archive for stable at vger.kernel.org where I can have a look at correct
submissions and check that my submission made it to the list?

Thanks for your help,

   Martin

submitting a patch for a stable tree

[Greg KH]

On Sun, Dec 17, 2017 at 08:24:36PM +0100, Martin Kaiser wrote:
> Dear all,
> 
> I tried to submit a patch for 4.14 that was already accepted upstream
> and is in linux-next and the 4.15-rcs.
> 
> To understand how this should be done, I looked at
> https://www.kernel.org/doc/html/v4.14/process/stable-kernel-rules.html
> and tried to follow Option 2. It looks like I didn't get it right.
> 
> 
> I started with a tree that contains the patch and ran
> 
> git format-patch -1 <commit id>
> 
> and then
> 
> git send-email --to stable at verg.kernel.org \
>    --cc <the original maintainer and reviewers> \
>    --annotate <patch file>
> 
> I added the upstream commit id above the original commit message and a
> tag line
> 
> Cc: <stable@vger.kernel.org> # 4.14.x
> 
> to the patch and sent it out.

You did?  Was this on December 12:
	Subject: [PATCH] mfd: fsl-imx25: Clean up irq settings during removal
?

If so, I totally missed it (just now dug in my archives to find it.)

> Is there anything that's wrong or missing? Is there a mailing list
> archive for stable at vger.kernel.org where I can have a look at correct
> submissions and check that my submission made it to the list?

There is an archive, yes, I think vger lists it.

As for what to do next time, I ignored this as I didn't know what to do
with it.  For some reason I thought it was just a "normal" patch being
sent to the subsystem, sorry.

Next time put below the --- line something like "Can you queue this up
for 4.14?"

Or even a simpler email would be:
	Can you please include git commit id 18f773937968 ("mfd:
	fsl-imx25: Clean up irq settings during removal") in the 4.14
	stable tree?  I forgot to tag it when I submitted it to the mfd
	subsystem.

And I can take it from there.

Care to try that?

And also, you can just email the stable list in response to your
original message saying "Just curious as to the state of this."  I do
get a ton of email, and sometimes things fall through the cracks, like
this time.  Being reminded after a week or two is not a problem, if you
don't get a response, it's usually required :)

thanks,

greg k-h

submitting a patch for a stable tree

[Greg KH]

On Sun, Dec 17, 2017 at 09:23:45PM +0100, Greg KH wrote:
> On Sun, Dec 17, 2017 at 08:24:36PM +0100, Martin Kaiser wrote:
> > Dear all,
> > 
> > I tried to submit a patch for 4.14 that was already accepted upstream
> > and is in linux-next and the 4.15-rcs.
> > 
> > To understand how this should be done, I looked at
> > https://www.kernel.org/doc/html/v4.14/process/stable-kernel-rules.html
> > and tried to follow Option 2. It looks like I didn't get it right.
> > 
> > 
> > I started with a tree that contains the patch and ran
> > 
> > git format-patch -1 <commit id>
> > 
> > and then
> > 
> > git send-email --to stable at verg.kernel.org \
> >    --cc <the original maintainer and reviewers> \
> >    --annotate <patch file>
> > 
> > I added the upstream commit id above the original commit message and a
> > tag line
> > 
> > Cc: <stable@vger.kernel.org> # 4.14.x
> > 
> > to the patch and sent it out.
> 
> You did?  Was this on December 12:
> 	Subject: [PATCH] mfd: fsl-imx25: Clean up irq settings during removal
> ?
> 
> If so, I totally missed it (just now dug in my archives to find it.)

So I've now queued this up to 4.14.y and 4.9.y, does it need to go any
further back?

thanks,

greg k-h

submitting a patch for a stable tree

[Martin Kaiser]

Hello Greg,

Thus wrote Greg KH (greg at kroah.com):

> You did?  Was this on December 12:
> 	Subject: [PATCH] mfd: fsl-imx25: Clean up irq settings during removal
> ?

yes, that was what I submitted.

> If so, I totally missed it (just now dug in my archives to find it.)

> > Is there anything that's wrong or missing? Is there a mailing list
> > archive for stable at vger.kernel.org where I can have a look at correct
> > submissions and check that my submission made it to the list?

> There is an archive, yes, I think vger lists it.

The gmane.org achive listed there doesn't work. Someone added a link to
the spinics.net archive recently, this is working.

> As for what to do next time, I ignored this as I didn't know what to do
> with it.  For some reason I thought it was just a "normal" patch being
> sent to the subsystem, sorry.

> Next time put below the --- line something like "Can you queue this up
> for 4.14?"

Ok, understood. I'll do that next time.

> Or even a simpler email would be:
> 	Can you please include git commit id 18f773937968 ("mfd:
> 	fsl-imx25: Clean up irq settings during removal") in the 4.14
> 	stable tree?  I forgot to tag it when I submitted it to the mfd
> 	subsystem.

> And I can take it from there.

> Care to try that?

Sure. But you beat me to it and queued the patch already ;-)

> And also, you can just email the stable list in response to your
> original message saying "Just curious as to the state of this."  I do
> get a ton of email, and sometimes things fall through the cracks, like
> this time.  Being reminded after a week or two is not a problem, if you
> don't get a response, it's usually required :)

Ok, just wanted to check first if I submitted the patch correctly.

Anyway, thanks for the quick repsonse and for queuing the patch.

   Martin

submitting a patch for a stable tree

[Martin Kaiser]

Thus wrote Greg KH (greg at kroah.com):

> So I've now queued this up to 4.14.y and 4.9.y, does it need to go any
> further back?

No, it seems that the fsl-imx25-tsadc driver was added after the 4.4
release.

Thanks,
   Martin