kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Guidelines for Submitting an RFC PATCH
Date: Tue, 13 Mar 2018 19:35:58 +0100	[thread overview]
Message-ID: <20180313183558.GA31153@kroah.com> (raw)
In-Reply-To: <CABGNecyPgJ82QoDbzSU+MJ4ctnmz-_AA2qGzY-4EyAQ3wNbk=g@mail.gmail.com>

On Tue, Mar 13, 2018 at 08:52:01AM -0700, Joe Smith wrote:
> By conformant I mean for example that it has to compile or if the
> patch consists of a series of patches each patch applied individually
> should compile. That is a lot of work for something that is just being
> presented to ask for an opinion.

If you want other people to do work for you in reviewing code, you need
to make it as easy as possible for them to do that.  By showing that you
put in as little effort as necessary, that indicates to me that I should
put in little, if no, effort as well.  How do I know you are going to
then later on do the correct thing?  If not, that means my limited time
that I gave to you was wasted.

If you show that you care enough to do the job correctly, then I know
you are more invested in doing the right thing and so, I too will put in
the effort.

And really, this goes for almost everything in life, not just boring
kernel patches :)

good luck!

greg k-h

      parent reply	other threads:[~2018-03-13 18:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 19:26 Guidelines for Submitting an RFC PATCH Joe Smith
2018-03-12 19:56 ` valdis.kletnieks at vt.edu
2018-03-12 20:42   ` Greg KH
2018-03-12 22:48     ` Joe Smith
2018-03-13  7:28       ` Greg KH
2018-03-13 15:52         ` Joe Smith
2018-03-13 18:10           ` valdis.kletnieks at vt.edu
2018-03-13 22:01             ` Joe Smith
2018-03-13 18:35           ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313183558.GA31153@kroah.com \
    --to=greg@kroah.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).