From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: SPDX identifier question for vboxvideo
Date: Sat, 2 Jun 2018 10:03:15 +0200 [thread overview]
Message-ID: <20180602080315.GA5345@kroah.com> (raw)
In-Reply-To: <fc1675e0134747069a6b24c31141912c@pid42.net>
On Fri, Jun 01, 2018 at 04:51:45PM -0300, Fabio Rafael da Rosa wrote:
> Hi all,
>
> I was preparing patch to fix the use of load/unload drm_driver hooks and use
> drm_dev_alloc and drm_register. When I was preparing the patch, I run
> checkpath and got a warning regarding SPDX tag identifier for the files. As
> this is the first patch I try to send, I though it would be a good idea to
> send a patch to fix this warning first, as this is a simpler one, and I
> could check all my setup with it. But, when I read the license for these
> files, I see that MODULE_LICENSE defines 'GPL and additional rights'...
> As the GPL version is not specified, which one is the default ? GPL2+ ?
> And, in the case of 'additional rights'... while reading the top of the
> file, it more like a permissive license, but, it is not clear if it would be
> MIT or BSD ...
I would leave the marking of SPDX tags to people who know the code and
license history. If you are not comfortable with them, I would not
recommend it at all.
Just work on your patch and ignore the checkpatch warnings in portions
that you did not touch.
thanks,
greg k-h
prev parent reply other threads:[~2018-06-02 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 19:51 SPDX identifier question for vboxvideo Fabio Rafael da Rosa
2018-06-02 8:03 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180602080315.GA5345@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).