From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C5DC3A5A5 for ; Tue, 3 Sep 2019 06:52:22 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3745215EA for ; Tue, 3 Sep 2019 06:52:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="C5q6r7uj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="QVCjQCLe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3745215EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces+kernelnewbies=archiver.kernel.org@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.92) (envelope-from ) id 1i52fs-00011G-Ft for kernelnewbies@archiver.kernel.org; Tue, 03 Sep 2019 02:52:20 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i52e6-0007Is-Vt for kernelnewbies@kernelnewbies.org; Tue, 03 Sep 2019 02:50:31 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3278321F14; Tue, 3 Sep 2019 02:50:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 03 Sep 2019 02:50:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=joAUj19/mXGtQqcolfpus/sMQ1g UhtGjAVErLgWTJmo=; b=C5q6r7ujL9Z6u3vv28Y4hw8I5A+uGe7cnrSyX7gHzAV ++SSyZgK4esyqZY+fuLM9rxqxeIo7J5uW6vepkUJSdwEUdHygw6ycf8sTW4RI6Yp GpWqCA8yOsiGRSqOdZ0+X8msEKwnLyRGPMe4b4/8FD4wejfGKh6q392TjmQZ9xf6 1w+ZN8JU2OtX0OQPnkiEbyJf3qK82a1SJz9C+neWNHy3512+5OqWqdTL08VWIwY0 NA7FoQ+p3kw3EYoqfQwETAKVgVn2Rkp3qqdky4xTJt/3o+Lci+bbv1HxNBkY/pg4 0JgbIpXP9kzmxz6aNomVExjL4YDujyOyn7u05LyM4rA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=joAUj1 9/mXGtQqcolfpus/sMQ1gUhtGjAVErLgWTJmo=; b=QVCjQCLeLabXYNuiNAwFF9 2jNZAInk5jYf7ybeC72V1TJ1yWGZDi3d1N3dqZJVyjm3U90TSc9vXQXvChPxnn7v Fy3o4WcA7alXyMX4CEjbP3UmeRWxxl/tWijvyn+caty9f5ngBPtRuUdYEHvx84OI HEJmGPYQaG5YiBnSEtPKOec6kPFGcBuZpcO64Qwq7JYaBt08HWHlIgZ0/JGdP9GZ nGkdK834rIizfwy6ECQBTBPA2rdAmCNqhUW4MgiuYfW3QjzcLXCOtOQPGm8GniU/ FAzo6lV9VO/ABrm0mguEjzfh6u7b10FHYcQL1Zaf7oDJedsF2GE9RiuYDG0+m3xw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudejuddgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefirhgv ghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrkeelrd dutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhen ucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 7C32680061; Tue, 3 Sep 2019 02:50:29 -0400 (EDT) Date: Tue, 3 Sep 2019 08:50:27 +0200 From: Greg KH To: Pablo Pellecchia Subject: Re: Staging/netlogic coding style issues with struct Message-ID: <20190903065027.GB19225@kroah.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Cc: kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces+kernelnewbies=archiver.kernel.org@kernelnewbies.org On Tue, Sep 03, 2019 at 01:26:17AM -0300, Pablo Pellecchia wrote: > Greetings, > > I'm fixing some issues on the staging/netlogic directory and I see that > checkpatch.pl is throwing the following warnings on some files: > > > > *WARNING: struct should normally be const#9: FILE: > platform_net.h:9:+struct xlr_net_data {* > > A similar issue is reported when we declare a variable of type struct > , but in this case warning is reported on the struct definition > itself. > > How can we fix this? You mark the structures const in the correct places as needed. Sometimes it is not needed, checkpatch is just a perl script and tries to do the best it can. Please read up on how C uses const if you are unfamiliar with what that means. thanks, greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies