From: Suraj Upadhyay <usuraj35@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: kernelnewbies@kernelnewbies.org
Subject: Re: new TODO list item
Date: Fri, 10 Jul 2020 20:04:25 +0530 [thread overview]
Message-ID: <20200710143425.GA2549@blackclown> (raw)
In-Reply-To: <20200421112616.GA29634@infradead.org>
[-- Attachment #1.1: Type: text/plain, Size: 1717 bytes --]
On Tue, Apr 21, 2020 at 04:26:16AM -0700, Christoph Hellwig wrote:
> On Tue, Apr 21, 2020 at 01:53:25PM +0530, Suraj Upadhyay wrote:
> > On Tue, Apr 21, 2020 at 10:12:57AM +0200, Christoph Hellwig wrote:
> > > Hi Janitors,
> > >
> > > if someone feels like helping with a fairly trivial legacy API, the
> > > wrappers in include/linux/pci-dma-compat.h should go away. This is
> > > mostly trivially scriptable, except for dma_alloc_coherent, where
> > > the GFP_ATOMIC passed by pci_alloc_consisteny should usually be replaced
> > > with GFP_KERNEL when not calling from an atomic context.
> >
> > Hii Christoph,
> > This is my first time posting to kernel-janitors. I would be glad to
> > help with this task but suggest me if I should get started with
> > something else.
>
> Sure, feel free to get started. A coccinelle script to do the grunt
> work might be useful, though.
Hii Christoph,
I nearly forgot about this, and now I would like to complete
this task.
However, even after two months I am still a newbie and there are a few
questions that I would like to ask :
1. Multiple files will be affected by this change, who do you think
I should send my patches to ??
2. Should I send my patches as a patchset of multiple small patches
chaging a particular API for e.g. sending all patches that change
pci_map_single() to dma_map_single() in one file in the same patchset ??
3. I literally have little idea on how to change the comments and
docs which refer to these APIs.
4. And what if a maintainer likes the previous APIs for simplicity
and rejects the patches that try to change them ??
Thanks,
Suraj Upadhyay.
CCing Kernelnewbies@kernelnewbies.org
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
parent reply other threads:[~2020-07-10 14:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200421112616.GA29634@infradead.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710143425.GA2549@blackclown \
--to=usuraj35@gmail.com \
--cc=hch@infradead.org \
--cc=kernelnewbies@kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).