From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42340C433DF for ; Thu, 27 Aug 2020 13:20:11 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F32A52177B for ; Thu, 27 Aug 2020 13:20:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="SqNqBQXw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="b99RQq+8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F32A52177B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1kBHon-0003Gn-3E; Thu, 27 Aug 2020 09:19:53 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kBHok-0003Gb-0u for kernelnewbies@kernelnewbies.org; Thu, 27 Aug 2020 09:19:51 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 94642E23; Thu, 27 Aug 2020 09:19:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 27 Aug 2020 09:19:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=K0SlCEpbPeQJxFz9F7df453pcNM W5ufRCLY5QvHpkfY=; b=SqNqBQXwpTJFTXiVDSMdXF4mhzPoBcqjcgFJf5F7T9b VoJhYj7c5URWkTXb9v42rZNkPppcl278h5x8zO7dx2dJoWwAJZPA32g/qfXIu6OE uIF+1t4arlk0Jed2Xe8eqn/kmjnGHGXwVrd4O/gZrWm7rzntI2FqMtHmVO4LvO4Q 7/zeHjtmfdbAZyiE/iDYYIo+lX562iwqjG/PP4XZTFoykmgkpslglOuJj4VmD7J2 ABxNenwk5ML77w+A3vFWV3WBQomhplhpa4MwHDyy+T2N3rK7ZcqG/6TxBZutnY7k UuTlUmDaMb58jUtQgfZ+FAr0F6cPllMLIHurG1GFICg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=K0SlCE pbPeQJxFz9F7df453pcNMW5ufRCLY5QvHpkfY=; b=b99RQq+8fOFlB8e2w7Fb3D CI5IwQ/2t7tq4WMt+zkOaIqRVIuiXgPNkw/IGvPCsgRB7gJj04by4gY30NSTeW0v 1Dd4V8ao1ngX3s7LOeRBhAYBkuThnMuQyaZwjQlG+1KCG+ygbvbl71V6eu7ePcNo PpawBcFSScsoWfj+SVskNn9BvEOsBL6nOl9UKZMLO6WfmviBIKRfj2KxDzjP/DGq vyrLGL3vml8d9EvsWzT5l/X69kGajyDKkwJBtr6l5Gy7IMwDcyd2MM50GeQtp5FD p4HJaR3AgHaefTKv6fwsjA2TeY6338fUDA2f7MnC0ZOqdNyuxcPBx3UrUPfY+1Lw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddvgedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeeuteejie ethfejjeejhfffkeetleegveduleekleehffefjeehtedvveevjeevhfenucffohhmrghi nhepmhgrihhlqdgrrhgthhhivhgvrdgtohhmnecukfhppeekfedrkeeirdekledruddtje enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgv gheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 850173280059; Thu, 27 Aug 2020 09:19:45 -0400 (EDT) Date: Thu, 27 Aug 2020 15:19:59 +0200 From: Greg KH To: Garrit Franke Subject: Re: Please give advise about my first patch attempt Message-ID: <20200827131959.GA547311@kroah.com> References: <8489736254099146458@scdbackup.webframe.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Thomas Schmitt , Linux Kernel List X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Thu, Aug 27, 2020 at 11:52:56AM +0200, Garrit Franke wrote: > Hi Thomas, > > Noob here. > > On Thu, Aug 27, 2020 at 10:49 AM Thomas Schmitt wrote: > > > > Commit 210ba1d1724f5c4ed87a2ab1a21ca861a915f734 of january 2008 switched > > sr_drive_status() away from indirectly using sr_do_ioctl() for sending > > TEST UNIT READY commands. sr_do_ioctl() has a wait-and-retry loop for > > the drive's intermediate sense reply: > > In a recent Patch of mine, Greg nicely pointed out that commits should > have a standard format across mailing lists: sha ("Commit Message"). > > See: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2235132.html That is also documented in the ever-growing submitting patches document somewhere... thanks, greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies