From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC6FC4338F for ; Thu, 19 Aug 2021 03:01:14 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3A8C60720 for ; Thu, 19 Aug 2021 03:01:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A3A8C60720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mGYIh-0007ey-HV; Wed, 18 Aug 2021 23:01:03 -0400 Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mGY9F-0005Ut-JI for kernelnewbies@kernelnewbies.org; Wed, 18 Aug 2021 22:51:19 -0400 Received: by mail-ot1-x329.google.com with SMTP id l36-20020a0568302b24b0290517526ce5e3so6809089otv.11 for ; Wed, 18 Aug 2021 19:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sXEks3JI+ONhTh8Qk52K9Fzoc117gt7kl+QmqDHFZ5c=; b=Xt4zZ+NS/ome28aS6rZPPnoQIgvLjCXE1je8BOkKS+mzqJeVv5MJlcZ3ppWG4G3dZJ I75AU1qbeRx1zb0TaOOyeCAas3nY7xnvszopf1FXTqfOgxk9G/JRhYS2xjHUVy1YfW9J uVYwzyIs2ourcYJyOk5LrMTMqd+nKkxm4zfPAYPUL2Ct+BwSSYT10mJbFumr3St8xQ2l c8DwKpIZBNY+Jhm4Ij9iJjD/Zh2r33hTfHsAe0KQkXEqX5fPcVi6UA4m6QZj8fpgGq41 R2vCnSN3m90BXH+SLHdcayd/CbG5Yf1q+OBJ7ZXtvLeSuBeWgGSLICG7TFA85BMECJ+T esFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sXEks3JI+ONhTh8Qk52K9Fzoc117gt7kl+QmqDHFZ5c=; b=TgKap3mW6TKZl8efHOcggjD2EYtCkjxzZbZd+p4xWYWJE5pp6CM44DnWDK/tj/VXZD OB8nt0oje93U/nLaVFuBGjp/DSglKQ0lN7xN4aT5Or+gjsxFipY+vqM+Dmoe6EqKBqDn HMl+pS8E9c3CrGn1lw1SZFfaNQBrQhF7YidIQTXZxsdcLoJJQfIfOm+tQZDu08HpabwH bqV1mGMmcQMRT05SJjMD3CD9B7EnRouqgQgqhiqafKxPXsXHQhvHN90Ykh+UnJWiv+d2 BxQZsXN6jujs6c0sO5DCPHmfj/D7Fwc16T6K634fZKbQoVQJ+T7G84bWd0p3fFv4D5vC a1aQ== X-Gm-Message-State: AOAM530SuNA/3q3O41CWwUJFBe87MpsjTL11A0iOAZtT4PkGI5eKmmky +xxKSbMDWgOSYubuVpSK6mU= X-Google-Smtp-Source: ABdhPJz0J6AMMiJdieUg0LdlebyEWi5moitw0Ifbz/1N1W5wSKMYt8S+kjeiV2iLpIhAj/lcOfhbCA== X-Received: by 2002:a9d:6003:: with SMTP id h3mr9887837otj.42.1629341474721; Wed, 18 Aug 2021 19:51:14 -0700 (PDT) Received: from ian.penurio.us ([47.184.51.90]) by smtp.gmail.com with ESMTPSA id w15sm156792oiw.19.2021.08.18.19.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 19:51:14 -0700 (PDT) From: Ian Pilcher To: linux-block@vger.kernel.org, linux-leds@vger.kernel.org Subject: [RFC PATCH v3 14/18] ledtrig-blkdev: Add mode (read/write/rw) sysfs attributue Date: Wed, 18 Aug 2021 21:50:49 -0500 Message-Id: <20210819025053.222710-15-arequipeno@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210819025053.222710-1-arequipeno@gmail.com> References: <20210819025053.222710-1-arequipeno@gmail.com> MIME-Version: 1.0 Cc: axboe@kernel.dk, kabel@kernel.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org Show all modes, with current mode in square brackets, in show function Signed-off-by: Ian Pilcher --- drivers/leds/trigger/ledtrig-blkdev.c | 67 +++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/drivers/leds/trigger/ledtrig-blkdev.c b/drivers/leds/trigger/ledtrig-blkdev.c index 481b2d142db2..88e2a11af1a9 100644 --- a/drivers/leds/trigger/ledtrig-blkdev.c +++ b/drivers/leds/trigger/ledtrig-blkdev.c @@ -591,3 +591,70 @@ static ssize_t blkdev_time_store(struct device *const dev, return count; } + + +/* + * + * LED mode device attribute + * + */ + +static const struct { + const char *name; + const char *show; +} blkdev_modes[] = { + [LEDTRIG_BLKDEV_MODE_RO] = { + .name = "read", + .show = "[read] write rw\n", + }, + [LEDTRIG_BLKDEV_MODE_WO] = { + .name = "write", + .show = "read [write] rw\n", + }, + [LEDTRIG_BLKDEV_MODE_RW] = { + .name = "rw", + .show = "read write [rw]\n", + }, +}; + +static ssize_t blkdev_mode_show(struct device *const dev, + struct device_attribute *const attr, + char *const buf) +{ + const struct ledtrig_blkdev_led *const led = + led_trigger_get_drvdata(dev); + + return sprintf(buf, blkdev_modes[READ_ONCE(led->mode)].show); +} + +static ssize_t blkdev_mode_store(struct device *const dev, + struct device_attribute *const attr, + const char *const buf, const size_t count) +{ + struct ledtrig_blkdev_led *const led = led_trigger_get_drvdata(dev); + const char *const mode_name = blkdev_skip_space(buf); + const char *const endp = blkdev_find_space(mode_name); + const ptrdiff_t name_len = endp - mode_name; /* always >= 0 */ + enum ledtrig_blkdev_mode mode; + + if (name_len == 0) { + pr_info("blkdev LED: empty mode\n"); + return -EINVAL; + } + + for (mode = LEDTRIG_BLKDEV_MODE_RO; + mode <= LEDTRIG_BLKDEV_MODE_RW; ++mode) { + + if (blkdev_streq(blkdev_modes[mode].name, + mode_name, name_len)) { + WRITE_ONCE(led->mode, mode); + return count; + } + } + + pr_info("blkdev LED: invalid mode (%.*s)\n", (int)name_len, mode_name); + return -EINVAL; +} + +static struct device_attribute ledtrig_blkdev_attr_mode = + __ATTR(mode, 0644, blkdev_mode_show, blkdev_mode_store); -- 2.31.1 _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies