From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3232C3DA59 for ; Tue, 16 Jul 2024 19:03:19 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.97.1) (envelope-from ) id 1sTnSH-000000004fj-3O0L; Tue, 16 Jul 2024 15:03:17 -0400 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.97.1) (envelope-from ) id 1sTnNz-000000000Qo-14Fe for kernelnewbies@kernelnewbies.org; Tue, 16 Jul 2024 14:58:51 -0400 Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-807007b8dd1so4811839f.2 for ; Tue, 16 Jul 2024 11:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721156311; x=1721761111; darn=kernelnewbies.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kihqcq8gEwvlFuKQVqVa3kRjj6JIPweX7rDvgcIT9h8=; b=QE4+ZZeV0cvOiJQkMXuMhakIaZ9I5Gpq942ThBhCEWyyPDENO031qtHN/bfYKyDJ6r u0offftSeL1jfXhTgv5Sky1HNfE0Hai6foGI0mdmyfWJV+wrH0RhVTvHwysxP3t0Gz8+ vV48KY+uUGL8LQOSFiM5HQ3L5kZETV736kcOt2tdU4MLPTf7zg2IX9l/mjn3N5sHiJJ9 fHJsjC5IKuZh6vMKJkJw+EJGJmkt4K9YK0HI7QQgryij22klxmxBrK3CowUfIpdtrW6P jk30Kfku8e/BxVQ4vaDZIle7eyCAXDZhWJ0Zz37DLr85aUoaEUYJuIix5uSCRUfpNljO a3Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721156311; x=1721761111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kihqcq8gEwvlFuKQVqVa3kRjj6JIPweX7rDvgcIT9h8=; b=H+Yn+T6KG03y3svuSR8RTvuIpCHqAaQhKDuD3ovlsxh9NbHwM91W8/h0wI5KlqU9P8 3E+3523pj2hhQSmVm4HKoK1uON/uogpRDgBG46ZfxnFs91GJFwvGEB19GOBKvR1n/hTV IuVPtVr8C5d3iMLrYxPoRBLy1RwoN5oz8Pqej8AS0fMcVhh9VBRFSAIJKUTn8Fd8gK+s sXIlM7XJ4eN245rpMM+kMO2wlXJCFQi3f5aRVkLbIYaWQ56vr5mOMy0sN7N+yAMVfIFZ mmOtqn7hGyDpBeYxwcB4pjym8iBxXY6alaBlGuxnej4L16zHRsGi/I6QVzrCVm1nqMDM H+MQ== X-Forwarded-Encrypted: i=1; AJvYcCU+XeyIiR92S2f5Y3b0rGlUXXEV9sq2VCQxh8ZxZ7M1uCO5leGRGFse541PgJF8B5lRd58fcGqhnRtlhICSb06baGwKRH6w6CWB/K0XR+oK X-Gm-Message-State: AOJu0YyKSBOo9v0DnoTyEPp5sG6P148yBnvOZ2eejpXkNpoVzMdczRdx mrx/cbsF6GJXkSjtb8mcE/HgzY1o/D+F2nZbnDUKsaHBPMzhViGA X-Google-Smtp-Source: AGHT+IG/+jo69dsHArTBqixhUoufA4QPx32dYcoWi4IHunj5MWvseDBGOvH7eIX5hx3svsuPZC331g== X-Received: by 2002:a05:6602:601b:b0:80b:8cb:e9a2 with SMTP id ca18e2360f4ac-816c39b5f53mr47969539f.9.1721156311067; Tue, 16 Jul 2024 11:58:31 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4c210f23f1csm75301173.102.2024.07.16.11.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 11:58:30 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com Subject: [PATCH v9-resend 10/54] dyndbg: silence debugs with no-change updates Date: Tue, 16 Jul 2024 12:57:22 -0600 Message-ID: <20240716185806.1572048-11-jim.cromie@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716185806.1572048-1-jim.cromie@gmail.com> References: <20240716185806.1572048-1-jim.cromie@gmail.com> MIME-Version: 1.0 Cc: groeck@google.com, linux-doc@vger.kernel.org, Jim Cromie , yanivt@google.com, intel-gfx@lists.freedesktop.org, kernelnewbies@kernelnewbies.org, linux@rasmusvillemoes.dk, robdclark@gmail.com, dri-devel@lists.freedesktop.org, mcgrof@kernel.org, seanpaul@chromium.org, amd-gfx@lists.freedesktop.org, joe@perches.com, bleung@google.com, intel-gvt-dev@lists.freedesktop.org, ukaszb@chromium.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org In ddebug_apply_class_bitmap(), check for actual changes to the bits before announcing them, to declutter logs. no functional change. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 368381dbd266..8320cadeb251 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -595,7 +595,7 @@ static int ddebug_exec_queries(char *query, const char *modname) return nfound; } -/* apply a new bitmap to the sys-knob's current bit-state */ +/* apply a new class-param setting */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, unsigned long *new_bits, unsigned long *old_bits, const char *query_modname) @@ -606,8 +606,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, int matches = 0; int bi, ct; - v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, - query_modname ?: ""); + if (*new_bits != *old_bits) + v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, + *old_bits, query_modname ?: "'*'"); for (bi = 0; bi < map->length; bi++) { if (test_bit(bi, new_bits) == test_bit(bi, old_bits)) @@ -622,8 +623,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } - v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, - query_modname ?: ""); + if (*new_bits != *old_bits) + v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, + *old_bits, query_modname ?: "'*'"); return matches; } -- 2.45.2 _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies