From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F0DCC3DA49 for ; Tue, 16 Jul 2024 19:08:33 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.97.1) (envelope-from ) id 1sTnXL-0000000014F-42F7; Tue, 16 Jul 2024 15:08:31 -0400 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.97.1) (envelope-from ) id 1sTnOM-000000000bJ-2SwH for kernelnewbies@kernelnewbies.org; Tue, 16 Jul 2024 14:59:14 -0400 Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-8076cee8088so5534739f.0 for ; Tue, 16 Jul 2024 11:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721156332; x=1721761132; darn=kernelnewbies.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VIvOBtUs6wwUYmdF+Bm1LKjLjq3TMDH2Ljy+h6N5XvY=; b=SBXyfCc4/Xe57XCrpVYJK+XHJ7tVXuZPGmgMbNAeCRcZzrIWQKfP5suuHC1hSijIIz TMyjDbNR/3PBzK7fsUbngsj5gzjC35Wy8nwtLolyEyzQsvgPfpjU1LzLbQhaNwQX9IzK ig4SoWQtUor49KetKcteY4EbxauB+01YnOn5iE6MxSoWdX0s/L8xEIARXe660Gi3dpkB SQBpRmuG0oDY42oQJMwfWtDR23hzGO0koOCWcWOl6IF0tufavm+nY+NRLh+ork/cgZ8U 8y+Rdh5qXuyO2WXuCJEDt2Ia4WsRwc4Kl51iSOKpO4zbF7BcKUjuPAzp+zlPxlNoC8ut /fIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721156332; x=1721761132; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIvOBtUs6wwUYmdF+Bm1LKjLjq3TMDH2Ljy+h6N5XvY=; b=ZJszQaNpGM7vt2CMnp+y8z5O4ukGEpT/PBqMQ7s732BeiI1Ks5E7gYXgOpl2ItFK33 9o3xXiq3POt47DJvlN6VnaExZr62+wOCsb6xO1TG0n+BR1YuLmHs9w+ppKQ3GEE9rCiv cG3vTrLKFzOsBXdIepXtqzft9yktYOvNUOm8/5R2xXNXOMBnbcNJgLXVpsw/KT1I0w7b MxQ1luyX/wqfJzDTDoHihhWaEEtb2ECDDCHPYkIfyZRbCZAiDMteWZ/lyY+lx/NAGJiD e3uFH3UVkzRJW4da/wc2kW++zRkC1g2Bv477yrEiC4vGa5Qdl2WoEDVSbJiXKGW54KID W70A== X-Forwarded-Encrypted: i=1; AJvYcCWyMGRWF2chpjSyQmUt/zjU2QLLEoDEHRGO+X/ZJ7C4sij4mVSIkubq/91hIfCVQNA2tSEzspgw/yfvWllddQsb7xsvUTsp7f3G3nX946f5 X-Gm-Message-State: AOJu0YylfFkd7WPNjK4YFDv2sYvVlfhKc+4Tce8fr16xppBCOD24XMyq VfS4JQ97QI4BqbUPxg4K2fsqOqpg2YRlEova7LxKEIDyhe7dW2hC X-Google-Smtp-Source: AGHT+IGIzqzPIEDRHp4d7Lzv1bJMSuo67sIN7LKuY04te4B9L6LczQkAf5ej+65dlhPKvxI7KIqPPQ== X-Received: by 2002:a05:6602:13d0:b0:806:6b24:ee2c with SMTP id ca18e2360f4ac-816c5883f11mr40915339f.16.1721156331976; Tue, 16 Jul 2024 11:58:51 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4c210f23f1csm75301173.102.2024.07.16.11.58.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 11:58:51 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com Subject: [PATCH v9-resend 21/54] dyndbg: split multi-query strings with % Date: Tue, 16 Jul 2024 12:57:33 -0600 Message-ID: <20240716185806.1572048-22-jim.cromie@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716185806.1572048-1-jim.cromie@gmail.com> References: <20240716185806.1572048-1-jim.cromie@gmail.com> MIME-Version: 1.0 Cc: groeck@google.com, linux-doc@vger.kernel.org, Jim Cromie , yanivt@google.com, intel-gfx@lists.freedesktop.org, kernelnewbies@kernelnewbies.org, linux@rasmusvillemoes.dk, robdclark@gmail.com, dri-devel@lists.freedesktop.org, mcgrof@kernel.org, seanpaul@chromium.org, amd-gfx@lists.freedesktop.org, joe@perches.com, bleung@google.com, intel-gvt-dev@lists.freedesktop.org, ukaszb@chromium.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org Since commit 85f7f6c0edb8 ("dynamic_debug: process multiple debug-queries on a line") Multi-query commands have been allowed: modprobe drm dyndbg="class DRM_UT_CORE +p; class DRM_UT_KMS +p" modprobe drm dyndbg=< [ 203.902703] dyndbg: query parse failed [ 203.902871] dyndbg: processed 2 queries, with 0 matches, 2 errs bash: echo: write error: Invalid argument The '%' splits the input into 2 queries, and both fail. Given the limited utility of matching against the working parts of a format string "foo: %d bar %s", nothing is actually lost here. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 235d85765b63..dcec7b3657bb 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -596,7 +596,7 @@ static int ddebug_exec_queries(char *query, const char *modname) int i, errs = 0, exitcode = 0, rc, nfound = 0; for (i = 0; query; query = split) { - split = strpbrk(query, ";\n"); + split = strpbrk(query, "%;\n"); if (split) *split++ = '\0'; -- 2.45.2 _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies