From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92983C3DA59 for ; Tue, 16 Jul 2024 19:09:10 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.97.1) (envelope-from ) id 1sTnXv-000000001d6-2UT1; Tue, 16 Jul 2024 15:09:07 -0400 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.97.1) (envelope-from ) id 1sTnOQ-000000000hb-1zIi for kernelnewbies@kernelnewbies.org; Tue, 16 Jul 2024 14:59:18 -0400 Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-36da84df7adso208325ab.1 for ; Tue, 16 Jul 2024 11:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721156337; x=1721761137; darn=kernelnewbies.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c/0f+WJi9XEdvmbVJJgJH3wGY/BCuH90DF46SNcsdjc=; b=i/PYzDYTc0h399yr1j7+yEKMgOC4wfzdBd3+TMNzBj3EGTlsOtUeCJNhDDwV5eR8EX SZjKSlUNHmi/E0RJrttogOlIIcdwI5g2oTlQgWxJbDLRrJ22qrHpYQ3CIPVPN0V+cBko Qj2B8lDZeGsR4FuNfUspfQnapoBytd9BOD2Y3diG4mTCzK4WmPhnDzD6+DcD7VKIETYu Kamm+4iZ2VnKyA7wY94EX/3MLO/Kx8P+sLFbJkE4Dy+fBPAQ37v/pT6M8t0AG3VckLI1 mIIwXDxwcL3KScrGEZM0Da1tjcilALLxOtpSaWti+e7oze+S4x+dT1gy7C4u3cQngM4J kxFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721156337; x=1721761137; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c/0f+WJi9XEdvmbVJJgJH3wGY/BCuH90DF46SNcsdjc=; b=lyrxyfjnvCRFzRwvc7prlazOPmPr1Dd3P4QbTIdesCv77gcySRgqv0Z2Y060Q8YShD kydk0M1L+pB42lsMA3Vgus6/tnUQUCVw8vyT9SKBO3nxrCsQsucjWAOHqdPmFznwelGp Wa5ACAyFFlM1ievNQidMTINhDr+Oc5R615v3RKyAf26VlbV9X+wH4SHE34QH/1ec5W1E 2pGjlRIck8qDulkWNr74XPabNhlDyjmVDHAvdga8RGaKsNC2I7AMrY1vGKFnKZPG0FA3 KsglPgMUTjyGlSNU/04hrhcJa//S76U2CgC8j8JnFYLABoD1MBdyD+SqKECzyJqEWvl6 jKPA== X-Forwarded-Encrypted: i=1; AJvYcCWa/dnumiw3xlWo0kTQZ/W4IVjkIQHP+WCcCKlddFL1obg5iU9MxNnP1h0UY31KJYhQe5BTuoG9EcYOkDyjL+WX1FXhIdRDWG8BeW9aCVR7 X-Gm-Message-State: AOJu0YxW/xtXoY4Z3e0OzoWw52oPUJN6XJ/hpz7mn8njYdFpDPDuAroB 6Fzj2bxP+j/8StKXkLN0MTPziovU3sxdLOs8geNbU4rVqip8fZ9n X-Google-Smtp-Source: AGHT+IEi4sdjxzQ0oudUt7GMdorsoDaH0Xjh0/KlGssDHL3rDixHQ7EbnOzUaj0Aj/gbK9+Ua+nMLA== X-Received: by 2002:a05:6e02:1a04:b0:380:92fd:c4fc with SMTP id e9e14a558f8ab-3950f2854b3mr2319965ab.14.1721156337088; Tue, 16 Jul 2024 11:58:57 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4c210f23f1csm75301173.102.2024.07.16.11.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 11:58:56 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com Subject: [PATCH v9-resend 25/54] dyndbg-doc: explain flags parse 1st Date: Tue, 16 Jul 2024 12:57:37 -0600 Message-ID: <20240716185806.1572048-26-jim.cromie@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716185806.1572048-1-jim.cromie@gmail.com> References: <20240716185806.1572048-1-jim.cromie@gmail.com> MIME-Version: 1.0 Cc: groeck@google.com, linux-doc@vger.kernel.org, Jim Cromie , yanivt@google.com, intel-gfx@lists.freedesktop.org, kernelnewbies@kernelnewbies.org, linux@rasmusvillemoes.dk, robdclark@gmail.com, dri-devel@lists.freedesktop.org, mcgrof@kernel.org, seanpaul@chromium.org, amd-gfx@lists.freedesktop.org, joe@perches.com, bleung@google.com, intel-gvt-dev@lists.freedesktop.org, ukaszb@chromium.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org When writing queries to >control, flags are parsed 1st, since they are the only required field. So if the flags draw an error, then keyword errors aren't reported. This can be mildly confusing/annoying, so explain it instead. This note could be moved up to just after the grammar id's the flags, and before the match-spec is detailed. Opinions ? Signed-off-by: Jim Cromie --- Documentation/admin-guide/dynamic-debug-howto.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index 7b570f29ae98..ccf3704f2143 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -106,6 +106,16 @@ The match-spec's select *prdbgs* from the catalog, upon which to apply the flags-spec, all constraints are ANDed together. An absent keyword is the same as keyword "*". +Note: because the match-spec can be empty, the flags are checked 1st, +then the pairs of keyword values. Flag errs will hide keyword errs: + + bash-5.2# ddcmd mod bar +foo + dyndbg: read 13 bytes from userspace + dyndbg: query 0: "mod bar +foo" mod:* + dyndbg: unknown flag 'o' + dyndbg: flags parse failed + dyndbg: processed 1 queries, with 0 matches, 1 errs + A match specification is a keyword, which selects the attribute of the callsite to be compared, and a value to compare against. Possible keywords are::: -- 2.45.2 _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies