From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 023DBC3DA59 for ; Tue, 16 Jul 2024 19:13:11 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.97.1) (envelope-from ) id 1sTnbo-000000004P8-3ZdE; Tue, 16 Jul 2024 15:13:08 -0400 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.97.1) (envelope-from ) id 1sTnOd-000000000xS-3MX1 for kernelnewbies@kernelnewbies.org; Tue, 16 Jul 2024 14:59:31 -0400 Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-8036ce6631bso5970739f.1 for ; Tue, 16 Jul 2024 11:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721156352; x=1721761152; darn=kernelnewbies.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+4FIF/HbRAgi1F45UWnC13uNax9+Z9AZXMw7KimFe8Y=; b=EoScNMW7V4X20YaRaHF689ytdHkTBtWcrdkjOpNROHnc4YuMrCyTe9foEeBl1yqscd HYmkt4adNL5/RsdJJsizDIpWs/+uGmauT5Sf+k4U7lzKnKnuc9HRgRCPy5M7e7vaGtPC xFzJR7mCLbp51weAXzuopOSOG5JAoo1kvtv5qjHIOoH7Ok0dPySfYqHlv/ZmVeQZUywL C/dyb1tmjnieZout/uKlCHppSflX4dzDvg5TZts8l4j5JWeoyuHO2InSsAdSXnBePXER 0ZtskiYF+pioRXCvBlSDMYGSqlZJ/B6XPJ+CNRcpgHkWkzu85vVM2wO8LCNAojc2JGKY 78DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721156352; x=1721761152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+4FIF/HbRAgi1F45UWnC13uNax9+Z9AZXMw7KimFe8Y=; b=Bt4JABKH/XltVPRqyXNEWs+yEG98hpRi29UuOV0DGVJaSKLgrkZ/54kpzOOGqbmtBe NBRt299vMo4SJE8NLjDVwGll+XteocXBCWHbQYAfGDQDtY4jV4o5jMBytijM3ohFt+J0 i8SWnDonShn4G/61UKVrBiQTQtv/Abq7dDHETdERZtsNpPJPG40qjvAZNWvvaiZdPRAD Gefao0rCVzcfLctr5iKPXmleWXgOrmJJkft+TR7Pgo84T96wQm5Bt3Uq2jyWg3ZF7dY0 f/4ezkZj/6jEvwR5cl9vvLthftuYcpjht3EqF+HXQQC0DrV8ssxp7zvMaOE2l0Uwo5O1 vmBQ== X-Forwarded-Encrypted: i=1; AJvYcCWeCOf3JsZQ1CuYkkbZhkTW1afdiFSZJifEzDPsB065qUfzxY+/HKw3FeCD6bL7fC7++yuNEfrESL/CaT/DPkV3AK1UuSjdb5Q1sLaBsoKh X-Gm-Message-State: AOJu0YzRZgD4Rwgucgw02IVjF05m0uxDAArkerRtccsm/fPlaEaKVH7G O1pLOyEY2Qcx7FaJcZj3p0h2XfG6c1UeN4dh3iazolBDxSvGedrJ X-Google-Smtp-Source: AGHT+IGZMA5Wv6HVLe5IZ1iRd2dcUnxU5c1yurtEkdS2lNPSvZcznoMoprI5GhjJCIIceYNE78q/rQ== X-Received: by 2002:a05:6602:3ce:b0:7fb:790c:a317 with SMTP id ca18e2360f4ac-816c32c9ademr48017039f.6.1721156352545; Tue, 16 Jul 2024 11:59:12 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4c210f23f1csm75301173.102.2024.07.16.11.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 11:59:12 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com Subject: [PATCH v9-resend 37/54] drm-print: workaround unused variable compiler meh Date: Tue, 16 Jul 2024 12:57:49 -0600 Message-ID: <20240716185806.1572048-38-jim.cromie@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716185806.1572048-1-jim.cromie@gmail.com> References: <20240716185806.1572048-1-jim.cromie@gmail.com> MIME-Version: 1.0 Cc: groeck@google.com, linux-doc@vger.kernel.org, Jim Cromie , yanivt@google.com, intel-gfx@lists.freedesktop.org, kernelnewbies@kernelnewbies.org, linux@rasmusvillemoes.dk, robdclark@gmail.com, dri-devel@lists.freedesktop.org, mcgrof@kernel.org, seanpaul@chromium.org, amd-gfx@lists.freedesktop.org, joe@perches.com, bleung@google.com, intel-gvt-dev@lists.freedesktop.org, ukaszb@chromium.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org With CONFIG_DRM_USE_DYNAMIC_DEBUG=y, I'm getting an unused variable warning/error on 'category', though the usage follows immediately, in drm_debug_enabled(). This drops the local var and refs the field directly in the macro-call, which avoids the warning. For static-key optimized dyndbg, the macro doesn't actually check the category, since the static-key patches in the proper state. This is also likely why the auto var appears to be unused by the compiler. commit 9fd6f61a297e ("drm/print: add drm_dbg_printer() for drm device specific printer") CC: Jani Nikula Signed-off-by: Jim Cromie --- drivers/gpu/drm/drm_print.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c index c7455f2076b4..0980210a5146 100644 --- a/drivers/gpu/drm/drm_print.c +++ b/drivers/gpu/drm/drm_print.c @@ -183,11 +183,10 @@ void __drm_printfn_dbg(struct drm_printer *p, struct va_format *vaf) { const struct drm_device *drm = p->arg; const struct device *dev = drm ? drm->dev : NULL; - enum drm_debug_category category = p->category; const char *prefix = p->prefix ?: ""; const char *prefix_pad = p->prefix ? " " : ""; - if (!__drm_debug_enabled(category)) + if (!__drm_debug_enabled(p->category)) return; /* Note: __builtin_return_address(0) is useless here. */ -- 2.45.2 _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies