From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18085C3DA49 for ; Tue, 16 Jul 2024 18:59:12 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.97.1) (envelope-from ) id 1sTnOI-000000000uP-2SNm; Tue, 16 Jul 2024 14:59:10 -0400 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.97.1) (envelope-from ) id 1sTnNq-000000000Qg-3vkd for kernelnewbies@kernelnewbies.org; Tue, 16 Jul 2024 14:58:42 -0400 Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7fedb09357aso5192939f.2 for ; Tue, 16 Jul 2024 11:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721156303; x=1721761103; darn=kernelnewbies.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4gHhZlZC9lRM4IBPTZ/FMwaYyy9pebB6jMENYSRc4Ds=; b=W3MG+msBauzVZykWbaGuRIF7ml7xHIGuFTrpHLLM+RnKpaLmFPx+ShaIodVl2HaOH/ a96pF1OzxUYVwxlMH9QOAsZkP1eNSQhISBf1d5dK10bYMLwjmHwCBRws9g8LXFyqepir wgpbYglx3TBZUiFvbNty3Jhku0ZstnALL4rbgEEEo5aQAvho9uz6LI0o0opuZq4mAgGj bAKmgkZ3VIOq4aq7U0/2BbUVDFwWPbE0M87jlEhjts0V8FD3Tq3nUB9oM//slcZrQEKV Z+TtxflINkUKF0VdgEfKqwdoT0mfQiNU2/Qlc6x3ymheu5m+yJfppp8HyCX0rWaOoWmn sf4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721156303; x=1721761103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4gHhZlZC9lRM4IBPTZ/FMwaYyy9pebB6jMENYSRc4Ds=; b=NslIge8qqeNrofFrdu6RHcpSJtbh7p+hGoPlLql1xlbDo7Xa83dOJRNJa7kzkm4ez0 JiKnPWCTdIoU443EUHmXT8/SiZUZlgBxi9Qh1uvvsiMpsBaLsStjPokf+FeOg7rvTJhE UDadHz5ctoKJbFwIMUK+IH7R+k2JvkdWx2bYG2mDdKMQYkLKk2Fwx6Pum305cfLBhFZs Bp3LBPQmsL8LpElj4Pp3Oys6O2lyizWvMNaLNFzraZCDxmteaN1F5I8BzzblyQpHnvtp jh1YpLsFWhZOnEdVVA8PzQ9wpZek+NvWvPWvlVdOj4tHOgUZSd8WzuWfVZ4acfUwouAR kGVQ== X-Forwarded-Encrypted: i=1; AJvYcCXRqVCCfVQuBPWEq0s+ffR13lNzKS7sMaeyd5kF0KVOjGC4k8DnCrwsyb7riT8hluj0DxmjzmMe6z2wLFUbAeqOitClS0mCR5/ptzFSxban X-Gm-Message-State: AOJu0Yxa5YXal3np+f4hgkbiiUPJiF9Snr0E/UjXsG8S3lvuxLzaxcM3 Yep5r0qekt9BTowbi8uwCVSEuk9rjFfI7qCbq721vn2lFPx9hbzl X-Google-Smtp-Source: AGHT+IFIRyDhcxDXmtmK1HLnwwi/E2q7SlYEHNYrBcbDILq7EAQB2veK147HqsG4fbMsp7Bh70n8xA== X-Received: by 2002:a05:6602:6408:b0:804:411a:16fa with SMTP id ca18e2360f4ac-816c34e606bmr41423339f.9.1721156302764; Tue, 16 Jul 2024 11:58:22 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4c210f23f1csm75301173.102.2024.07.16.11.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 11:58:22 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com Subject: [PATCH v9-resend 03/54] dyndbg: reword "class unknown, " to "class:_UNKNOWN_" Date: Tue, 16 Jul 2024 12:57:15 -0600 Message-ID: <20240716185806.1572048-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716185806.1572048-1-jim.cromie@gmail.com> References: <20240716185806.1572048-1-jim.cromie@gmail.com> MIME-Version: 1.0 Cc: groeck@google.com, linux-doc@vger.kernel.org, Jim Cromie , yanivt@google.com, intel-gfx@lists.freedesktop.org, kernelnewbies@kernelnewbies.org, linux@rasmusvillemoes.dk, robdclark@gmail.com, dri-devel@lists.freedesktop.org, mcgrof@kernel.org, seanpaul@chromium.org, amd-gfx@lists.freedesktop.org, joe@perches.com, bleung@google.com, intel-gvt-dev@lists.freedesktop.org, ukaszb@chromium.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org When a dyndbg classname is unknown to a kernel module (as before previous patch), the callsite is un-addressable via >control queries. The control-file displays this condition as "class unknown," currently. That spelling is sub-optimal/too-generic, so change it to "class:_UNKNOWN_" to loudly announce the erroneous situation, and to make it exceedingly greppable. NB: pr_debugs are only alterable via >control, and to protect class'd debug's from unintended alteration, "class name" must be given to change them. Classmaps map known classes to reserved .class_ids (the 1..64 val range per module). Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index f2c5e7910bb1..73ccf947d4aa 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -1154,7 +1154,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p) if (class) seq_printf(m, " class:%s", class); else - seq_printf(m, " class unknown, _id:%d", dp->class_id); + seq_printf(m, " class:_UNKNOWN_ _id:%d", dp->class_id); } seq_puts(m, "\n"); -- 2.45.2 _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies