From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62ED7C3DA5D for ; Tue, 16 Jul 2024 18:59:24 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.97.1) (envelope-from ) id 1sTnOU-0000000017k-3b3E; Tue, 16 Jul 2024 14:59:22 -0400 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.97.1) (envelope-from ) id 1sTnNq-000000000Qh-420C for kernelnewbies@kernelnewbies.org; Tue, 16 Jul 2024 14:58:42 -0400 Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-7f97e794f34so4316739f.3 for ; Tue, 16 Jul 2024 11:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721156304; x=1721761104; darn=kernelnewbies.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=al8xZ+YlvhlhYR2QqHaR49xBruYIKMULtZOXYmr91IY=; b=ftR4lBH+vWXN1TFjwOYkp5zluzv8CunrgI1vXMoGi4fZkuLQergFMh/uxo6oDPvTLS sQWQ/L4Coe6uVsi3fSfGoh/xOiz44PDOa6STMcErCElbdimpnfqeOa+sQjQDNPxoMnA6 FcPwXoBWBiRW5ZVOuqEoxl/l7OUVjbYbx+eLcD1slFxKtKfj+5QeHsdlTt7MW5qTmo4v ip6orMZnaxLUOzUPcDUVp/z892yfX7DDHt8QGrWkBaPsFluHONMgFxAilaHDVL7C56kv wNjxclUV1AKbxtFpRFWUTCu1yQn1wMTpS738//ZPu/Mf16ltAyZ83pg/GtW8Qzoxy7Sm Mb6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721156304; x=1721761104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=al8xZ+YlvhlhYR2QqHaR49xBruYIKMULtZOXYmr91IY=; b=J50bCSo+4nL8d0AiG44ReAK6bVbLI4f7X/PC+orMvuPOJ8KC+4RHFoflS77cgZleUl DBo1hRklRkKAh0OjI5wBpaUZRT+49to+kZZ9pHPy6wkkqCyp/+3X23g48kt6vrnwglLs 2s4u6aAOxTT0U5PXuBoUtj+VWdFIKm0VOcHKW5CI1HO8v8lYnn4QXgU/hcys2y2wI/+s s2bevmBgt8XNXiSE5r1Cnc6tYrkKvfZcY2+HNIrHzmOrbL4+Nb10feoVzgppYT+1TaBq OcTjvnF3bWW3MSfa35dwtOlDxI4CJli782joC/dSCJELnzGzPjxw0ttwVTiJFFbFnXul Q80A== X-Forwarded-Encrypted: i=1; AJvYcCUEPA6VaOvRrTwcHi/g7oITm6WlICxsCYqAHunnFhPxYs9Cyuz4CXtP9aNyvkkseWIvYr2re/WiPEfc+wUoehyB7qZi1ekzcxxVpY9WlG5O X-Gm-Message-State: AOJu0Yw9uedB24ECIqufrA/J72AqAdcAyL4mWmTh19UuEGZaI7Z69QBh thzK+7Q+AvkV7lo8ZtjmfYqG+Tvs4PLI1SkEEZAVPcZIQkg3yJn8 X-Google-Smtp-Source: AGHT+IEHXZgya8fxlhk9i3WpXa3f6xKgjLFbnVvzZUw1PQJh5tx0JX3MrDcdRp4L7TxET69MO77yeg== X-Received: by 2002:a05:6602:3fc7:b0:7f9:bef6:2068 with SMTP id ca18e2360f4ac-816c35dac54mr41417039f.10.1721156303915; Tue, 16 Jul 2024 11:58:23 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4c210f23f1csm75301173.102.2024.07.16.11.58.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 11:58:23 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com Subject: [PATCH v9-resend 04/54] dyndbg: make ddebug_class_param union members same size Date: Tue, 16 Jul 2024 12:57:16 -0600 Message-ID: <20240716185806.1572048-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716185806.1572048-1-jim.cromie@gmail.com> References: <20240716185806.1572048-1-jim.cromie@gmail.com> MIME-Version: 1.0 Cc: groeck@google.com, linux-doc@vger.kernel.org, Jim Cromie , yanivt@google.com, intel-gfx@lists.freedesktop.org, kernelnewbies@kernelnewbies.org, linux@rasmusvillemoes.dk, robdclark@gmail.com, dri-devel@lists.freedesktop.org, mcgrof@kernel.org, seanpaul@chromium.org, amd-gfx@lists.freedesktop.org, joe@perches.com, bleung@google.com, intel-gvt-dev@lists.freedesktop.org, ukaszb@chromium.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least they will both see the same value. Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index ff44ec346162..b9afc7731b7c 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -124,7 +124,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 73ccf947d4aa..152b04c05981 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -799,7 +799,7 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp) case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; } -- 2.45.2 _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies