Patch Series

Patch Series

[Roger H Newell]

Hi all:

I have a question about creating a patch series. I'm working in
drivers/staging/wilc1000 fixing code style. If for example 2 errors are
reported by checkpatch.pl error A and error B, it seems logical that I
could fix all occurrences of error A as one patch and all occurrences of
error B in a second patch.

My question is, is it OK to fix all occurrences of error A across the files
inside drivers/staging/wilc1000 as one patch and all occurrences of error B
across all files inside drivers/staging/wilc1000 as a second patch?

The alternative would be to create a patch that fixes all errors of A and a
patch that fixes all errors of B per file ? In some cases there are so many
occurrences of a particular error across files it probably does make more
sense to create the patches per file.

Any thoughts or clarifications on this ?

Cheers:
Roger H. Newell
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20160216/b7fc84fc/attachment.html 

Patch Series

[Geyslan G. Bem]

Hello,

2016-02-16 10:38 GMT-03:00 Roger H Newell <newell.roger@gmail.com>:
> Hi all:
>
> I have a question about creating a patch series. I'm working in
> drivers/staging/wilc1000 fixing code style. If for example 2 errors are
> reported by checkpatch.pl error A and error B, it seems logical that I could
> fix all occurrences of error A as one patch and all occurrences of error B
> in a second patch.
>
> My question is, is it OK to fix all occurrences of error A across the files
> inside drivers/staging/wilc1000 as one patch and all occurrences of error B
> across all files inside drivers/staging/wilc1000 as a second patch?

I think it is. But you must rely on the maintainer's choice. Ask
him/her before sending.

>
> The alternative would be to create a patch that fixes all errors of A and a
> patch that fixes all errors of B per file ? In some cases there are so many
> occurrences of a particular error across files it probably does make more
> sense to create the patches per file.
>
> Any thoughts or clarifications on this ?

Ditto. But each case must be evaluated. Some changes (error A and B)
can be done in one line, so you have to analyze them.
A real case would be nice for a better exemplification.
>
> Cheers:
> Roger H. Newell
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>



-- 
Regards,

Geyslan G. Bem
hackingbits.com

Patch Series

[YU Bo]

--
Best Regards




At 2016-02-16 21:52:35, "Geyslan G. Bem" <geyslan@gmail.com> wrote:
>Hello,
>
>2016-02-16 10:38 GMT-03:00 Roger H Newell <newell.roger@gmail.com>:
>> Hi all:
>>
>> I have a question about creating a patch series. I'm working in
>> drivers/staging/wilc1000 fixing code style. If for example 2 errors are
>> reported by checkpatch.pl error A and error B, it seems logical that I could
>> fix all occurrences of error A as one patch and all occurrences of error B
>> in a second patch.
>>
>> My question is, is it OK to fix all occurrences of error A across the files
>> inside drivers/staging/wilc1000 as one patch and all occurrences of error B
>> across all files inside drivers/staging/wilc1000 as a second patch?
>
>I think it is. But you must rely on the maintainer's choice. Ask

>him/her before sending.
Greg said that per patch resolve per issue.Maybe i am wrong..:)
>
>>
>> The alternative would be to create a patch that fixes all errors of A and a
>> patch that fixes all errors of B per file ? In some cases there are so many
>> occurrences of a particular error across files it probably does make more
>> sense to create the patches per file.
>>
>> Any thoughts or clarifications on this ?
>
>Ditto. But each case must be evaluated. Some changes (error A and B)
>can be done in one line, so you have to analyze them.
>A real case would be nice for a better exemplification.
>>
>> Cheers:
>> Roger H. Newell
>>
>> _______________________________________________
>> Kernelnewbies mailing list
>> Kernelnewbies at kernelnewbies.org
>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>
>
>
>
>-- 
>Regards,
>
>Geyslan G. Bem
>hackingbits.com
>
>_______________________________________________
>Kernelnewbies mailing list
>Kernelnewbies at kernelnewbies.org
>http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20160217/2968b286/attachment.html 

Patch Series

[Valdis.Kletnieks at vt.edu]

>>> My question is, is it OK to fix all occurrences of error A across the files
>> inside drivers/staging/wilc1000 as one patch and all occurrences of error B
>> across all files inside drivers/staging/wilc1000 as a second patch?

Most maintainers would be perfectly OK with that.  And I'm pretty sure
that Greg KH (maintainer of drivers/staging) would accept that sort of
patch series.  If he isn't, I'm sure he'll correct me. :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20160217/5a10b0f8/attachment.bin