From: Valdis.Kletnieks@vt.edu (Valdis.Kletnieks at vt.edu)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Are Small Changes in kernel accepted as patches
Date: Sat, 21 Jun 2014 10:23:41 -0400 [thread overview]
Message-ID: <26608.1403360621@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sat, 21 Jun 2014 15:07:49 +0530." <53A5526D.9010702@gmail.com>
On Sat, 21 Jun 2014 15:07:49 +0530, karthik said:
> I was just going through the linux-next source and found a small change
> in one of the files. (Unnecessary else)
One-line patches that fix misleading logic are always welcome.
Just remember to:
1_ Read Documentation/SubmititingPatches.txt and follow the directions
2) In the patch description/ changelog explain *why* the 'else' is unneeded
as that's a change in the program logic. And then fix it correctly - if
the else is unneeded because you can prove it's deal code because the
if condition is always true, then the 'if then' part can probably be
fixed up as well....
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140621/db1304c4/attachment.bin
next prev parent reply other threads:[~2014-06-21 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 9:37 Are Small Changes in kernel accepted as patches karthik
2014-06-21 10:04 ` Jeff Kirsher
2014-06-21 10:27 ` Robert P. J. Day
2014-06-21 14:23 ` Valdis.Kletnieks at vt.edu [this message]
2014-06-21 14:42 ` karthik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26608.1403360621@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).