From: valdis.kletnieks@vt.edu (valdis.kletnieks at vt.edu)
To: kernelnewbies@lists.kernelnewbies.org
Subject: kernel development process question, patch review
Date: Tue, 21 Feb 2017 14:40:51 -0500 [thread overview]
Message-ID: <39273.1487706051@turing-police.cc.vt.edu> (raw)
In-Reply-To: <20170221013533.GA23212@eros>
On Tue, 21 Feb 2017 12:35:33 +1100, "Tobin C. Harding" said:
> If a reviewer makes a suggestion and one intends on making the change
> as suggested is it required (normal protocol) to reply stating that
> the you understand their suggestion and intend on implementing it or
> is this just noise. Should one simply re send the next version of the
> patch?
If it's something trivial, like changing a variable name to something
better, or clarifying a comment block, just cc: the reviewer on the next
revision of the patch.
If the reviewer suggest a major overhaul ("the goal looks good, but you
should probably use this other API" or similar), and it's something that
will take a bit of time, you should probably send a quick "Yes, I've put
that on my to-do list" note so the reviewer knows you read their note.
And of course, if you're not sure or disagree with the reviewer, that's
the time to start bouncing polite e-mails back and forth until you're on
the same page.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 484 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20170221/fac7d526/attachment.bin
prev parent reply other threads:[~2017-02-21 19:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 1:35 kernel development process question, patch review Tobin C. Harding
2017-02-21 7:02 ` Greg KH
2017-02-21 17:29 ` Ozgur Karatas
2017-02-21 17:32 ` Ozgur Karatas
2017-02-21 19:40 ` valdis.kletnieks at vt.edu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39273.1487706051@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).