kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: mueddib@goosey.org (Ozgur Karatas)
To: kernelnewbies@lists.kernelnewbies.org
Subject: My kernel patch was rejected with comments
Date: Wed, 22 Mar 2017 15:50:56 +0300	[thread overview]
Message-ID: <3960681490187056@web13j.yandex.ru> (raw)
In-Reply-To: <CA+aCy1FShobRbX2PgkPi_XPA4p-B0QWJ-QMyN1g5F_auza82uA@mail.gmail.com>



22.03.2017, 15:22, "Pranay Srivastava" <pranjas@gmail.com>:
> On Wed, Mar 22, 2017 at 5:09 PM, Prasant J <pj0585@gmail.com> wrote:
>> ?On Wed, Mar 22, 2017 at 4:02 PM, Tobin C. Harding <me@tobin.cc> wrote:
>>> ?On Wed, Mar 22, 2017 at 12:24:47PM +0530, Prasant J wrote:
>>>> ?Hi,

Hello,

firstly, you should attention here, please add rows to the answer lines, all developers like to read and habit.

example, you say Hi and I add new line and I say hi :)

>>>> ?I submitted a kernel patch and it was rejected with comments from
>>>> ?maintainer. Is it important to reply with a new patch against
>>>> ?maintainers response mail? Or it it ok if I send a new email with the
>>>> ?updated patch?
>>>
>>> ?You don't send the new patch as a reply. You may, if you wish, reply
>>> ?to the maintainer (or reviewer) with some comments that you understand
>>> ?and intend on implementing their suggestions (and thanks) or
>>> ?disagreeing as it may be.

Please don't send it again, find out why you are being objected and prove your right to be right.
we are striving for Linux development here and long as you work for Linux, 
you can discuss it with thousands of emails, not problem.

P.S.: everyone will read those who don't have time will not answer, I don't know.

>> ?@Tobin: Thanks a lot for your response. It is very helpful.
>>
>> ?How do I reply to the maintainer or how do people reply to
>> ?maintainers? gmail web gui may not be a good idea.. right?
>
> Make sure you select plain text mode from gmail web-gui while replying.

Please send only text, very simple e-mail. don't include ads, signatures, jpeg or even attachment.
it should be reply e-mail just text only :)

>> ?or Should I set up evolution or thunderbird for this?
>> ?(as mentioned here:
>> ?https://01.org/linuxgraphics/gfx-docs/drm/process/email-clients.html)
>
> Not really required but yeah nice to have this.
>
>>> ?You then re-work your patch and submit it as normal using git
>>> ?send-email. But you put v2 in the subject. You can use
>>>
>>> ?git format-patch -X --subject-prefix='PATCH v2' --numbered --cover-letter
>>>
>>> ?(where X is the number of commits to add to the series, assuming it is
>>> ?a series).
>>>
>>> ?In the cover letter add a section stating the changes since v1, for
>>> ?example
>>>
>>> ?v1 -> v2
>>> ??- use foo() instead of bar()
>>>
>>> ?If it is a single patch, you may wish to just edit the subject
>>> ?manually. Make sure you put the version change information below the
>>> ?--- line so it is not included if/when the patch gets merged.
>>
>> ?Could you please explain the last para? I did not understand "below
>> ?the --- line"
>>
>> ?Thanks & regards, Pj

Regards,

Ozgur

      reply	other threads:[~2017-03-22 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22  6:54 My kernel patch was rejected with comments Prasant J
2017-03-22 10:32 ` Tobin C. Harding
2017-03-22 11:39   ` Prasant J
2017-03-22 12:20     ` Pranay Srivastava
2017-03-22 12:50       ` Ozgur Karatas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3960681490187056@web13j.yandex.ru \
    --to=mueddib@goosey.org \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).