From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F92AC4332F for ; Fri, 9 Dec 2022 20:36:21 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.96) (envelope-from ) id 1p3k6F-0003AJ-0K; Fri, 09 Dec 2022 15:36:03 -0500 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1p3k6B-0003A5-32 for kernelnewbies@kernelnewbies.org; Fri, 09 Dec 2022 15:36:00 -0500 Received: by mail-qt1-x82b.google.com with SMTP id c15so4526913qtw.8 for ; Fri, 09 Dec 2022 12:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20210112.gappssmtp.com; s=20210112; h=message-id:date:content-transfer-encoding:mime-version:references :in-reply-to:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=wlcoCSdehFbt4MW7fGPQWzMgPHK+4V0BoROfDW/Q8Mw=; b=1uH5BGUR0G3CAuUq9ctqsJ35CSFUDzn5640HCV7ta9+5+TcsF2NKtsg/Uq6RdoOCm9 dUED2CkFoxTLOPp0H1NZ6TatwNqttwqt1NCv7niJZYH6VMiRjrVdOYzAqUehTiwm1+ej CXvk/PjAvBYmPZvEw6j6d6R0aidawbzqNTeJuBfPVyuGLh5alYp+gdMOaQJ5hC8Z6neS zsAbTUCwVj6oW6urUh2ZJXx+ArhP1/OC8WFkrpYLnkDzFyFyK0mY5F6lHB6ey2Uxy5ri CK7ozLgmLDaPVnshmq/fWQzwDfsiIZqKQrv0mWO6WlFzIKWUdrZuvFALA6Xm++D1VnwE wwKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:content-transfer-encoding:mime-version:references :in-reply-to:subject:cc:to:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wlcoCSdehFbt4MW7fGPQWzMgPHK+4V0BoROfDW/Q8Mw=; b=I5m669uBJesSnDE+jS0xGvpHpBPWHgvPvNjAdqyJCs78vbwZcQOVPJ9uoFgXOXcb2P rPtnZhFhicH3Am8ZSvTcwFJmgmzoj9LXP6qeyUDndMNGmYwBmsvEALgkIwPon4PPcNol kzQ1YxiVXpIB1p9MpUAnFXYsNRAM2xrUPrA3CiMu28o59fYifqhmV4VY2lTimRmrSIvG fZIDIxMzyw6sX13zY5kIU4i4zy9bUCZMVwrf+FzGcAX+FFJ+SeDlJF2EOnMXo3QpcOvU CuToEAaWa05ElpZ3DIsVIF55Y94dj0l5WFAbxkUKmB5Pm+JFyS2U8wPAwx+IC0U6paIg c4Gw== X-Gm-Message-State: ANoB5pnCBOzsvIEGiUmyzVzsedCs7g52vLBEFy6iU/g0DR0EO6BOclHe uHhFPIG46LLFn2IOV8Jpt6B/fw== X-Google-Smtp-Source: AA0mqf50YoyNGsrkgqM4PGjqtcJeRLjc2tzvidkJiogx54AGN+Sp8jnaegBDRZV3Vu2VKKoWdFYDFA== X-Received: by 2002:a05:622a:1e8a:b0:3a7:fef1:fa11 with SMTP id bz10-20020a05622a1e8a00b003a7fef1fa11mr8127045qtb.47.1670618155711; Fri, 09 Dec 2022 12:35:55 -0800 (PST) Received: from turing-police ([2601:5c0:c300:1f41::adb]) by smtp.gmail.com with ESMTPSA id x20-20020a05620a0b5400b006fab416015csm597901qkg.25.2022.12.09.12.35.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 12:35:55 -0800 (PST) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.10.0-pre 07/05/2021 with nmh-1.7+dev To: jim.cromie@gmail.com Subject: Re: unmap memory mapped with devm_ioremap_resource In-Reply-To: References: <518b1ec9-6d01-022e-de49-feb1f42c113c@fastree3d.com> <2d7fddcd-6289-dc63-6cf2-a5880057d6aa@fastree3d.com> Mime-Version: 1.0 Date: Fri, 09 Dec 2022 15:35:54 -0500 Message-ID: <408767.1670618154@turing-police> Cc: Constantine Shulyupin , kernelnewbies@kernelnewbies.org, Adrian Fiergolski X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3060654175316273293==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============3060654175316273293== Content-Type: multipart/signed; boundary="==_Exmh_1670618153_3562P"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --==_Exmh_1670618153_3562P Content-Type: text/plain; charset=us-ascii On Fri, 09 Dec 2022 12:58:20 -0700, jim.cromie@gmail.com said: > On Fri, Dec 9, 2022 at 9:14 AM Adrian Fiergolski wrote: > > Does the community have any other ideas? Or I am wrong, and devm_iounmap is enough? > I dunno, but it says you asked ~4 hrs ago. > I bet you could just try it and get an answer faster. > Do feel free to report back. Note that it *is* possible for something to *look* like it works, but it leaves dangling pointers or other hidden corruption that takes a while to surface. I once had to troubleshoot a userspace bug that worked fine on one system but blew up on another with a different malloc() - some 6 million malloc calls after the bug hit. Fortunately, the vast majority of kernel functions will return an error code if anything at all fishy happened, so just checking return codes on *everything* is usually good enough... --==_Exmh_1670618153_3562P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQEcBAEBCAAGBQJjk5wpAAoJEI0DS38y7CIcYVoH/31P1DfPMe7m2rlmed6vEwBl /W+N9IOWwSIjEfNfHhSN+jzq1vntP2fwTEQG++bqwb+cDW2S6OdnMap3rz3KHhyF wgiNXmcS1E5mSXmkuBEKkblHSjup24N/TBaRp3feLCDCHbL2FwWlQ108iND83+R8 DT/FavNP36fEJboxNlkqVagefUElnJUKzvl1c+jVfSe57lGtDvEbY5CjP9hDND0x B0IUMOtMk3sA7Ls+w/IfXQ3EqePHmKOAzLlD2FzVlOf3bdnKK85rP8pGnEcLU7AU qEtHK6mH4R3pD4H68m196xfosjrfy+5lEqgdIkOeDzM6pQltNT77etkuifGqkOo= =OfTe -----END PGP SIGNATURE----- --==_Exmh_1670618153_3562P-- --===============3060654175316273293== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============3060654175316273293==--