From: Valdis.Kletnieks@vt.edu (Valdis.Kletnieks at vt.edu)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] staging: Fix spacing between function name and parentheses
Date: Sun, 12 Oct 2014 18:34:12 -0400 [thread overview]
Message-ID: <4153.1413153252@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sat, 11 Oct 2014 14:52:40 +0100." <20141011135239.GL10301@carfax.org.uk>
On Sat, 11 Oct 2014 14:52:40 +0100, Hugo Mills said:
> On Sat, Oct 11, 2014 at 09:44:05AM -0400, nick wrote:
> > Thank you for your help, I'll study the code and see what I can do
> > about it. Do you have any suggestions of how to fix this checkpatch
> > warning?
>
> Ignore it. The checker has clearly triggered on a false positive --
> this is not a function call, and should not be held to that standard.
> (Take a look at where the macro is actually used, to see what's going
> on here). Move on to find something more interesting to fix.
Am I the only one suspicious of the fact that Nick found one of the
few false positives rather than one of the plentiful actual style
problems?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20141012/eb18dacc/attachment.bin
next prev parent reply other threads:[~2014-10-12 22:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 1:55 [PATCH] staging: Fix spacing between function name and parentheses Nicholas Krause
2014-10-11 4:58 ` Sudip Mukherjee
2014-10-11 5:23 ` Dave Tian
2014-10-11 6:08 ` Sudip Mukherjee
2014-10-11 6:11 ` Dave Tian
2014-10-11 8:27 ` Peter Senna Tschudin
2014-10-11 9:45 ` Sudip Mukherjee
2014-10-11 9:53 ` Kristofer Hallin
2014-10-11 13:44 ` nick
2014-10-11 13:46 ` Kristofer Hallin
2014-10-11 13:52 ` Hugo Mills
2014-10-11 14:17 ` nick
2014-10-11 15:25 ` karthik nayak
2014-10-11 22:18 ` nick
2014-10-12 22:34 ` Valdis.Kletnieks at vt.edu [this message]
2014-10-13 2:31 ` nick
2014-10-13 3:15 ` Valdis.Kletnieks at vt.edu
2014-10-13 4:55 ` Sudip Mukherjee
2014-10-14 15:38 ` Adrian Cornish
2014-10-14 18:11 ` Kernel Apprentice
2014-10-14 21:08 ` John de la Garza
2014-10-20 9:17 ` el_es
2014-11-02 0:34 ` Valdis.Kletnieks at vt.edu
2014-11-03 10:05 ` Bjørn Mork
2014-11-04 2:23 ` nick
2014-10-11 14:24 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4153.1413153252@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).