kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: lovelylich@gmail.com (李易)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [TCP]: question about counter in tcp_mark_head_lost
Date: Thu, 12 Jul 2012 13:44:24 +0800	[thread overview]
Message-ID: <4FFE6438.2060502@gmail.com> (raw)

hi all,
In tcp_mark_head_lost() fucntion, when sack enabled and fack disabled,
why does the packet counter variable "cnt" increase only when current skb is
marked as TCPCB_SACKED_ACKED?
code:
if (tcp_is_fack(tp) || tcp_is_reno(tp) ||
(TCP_SKB_CB(skb)->sacked & TCPCB_SACKED_ACKED))
cnt += tcp_skb_pcount(skb);

Is this right ? I have a question when retransmition queue looks as below:

sacked=0 --> sacked=SACK_ACKED --> sacked=0 --> sacked=SACK_ACKED
then, when we call tcp_mark_head_lost(sk, 1, 0)
this will mark the two skbs, which are previously marked 0 , as TCPCB_LOST.

So, this function marks two skbs as lost, although we pass parameter
"packets"
as "1".

I do not know why this function has this semantic , which is not
consistent with
its declaration.

Can anyone explanation this, thanks in advance.

                 reply	other threads:[~2012-07-12  5:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFE6438.2060502@gmail.com \
    --to=lovelylich@gmail.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).