How to contribute to latest -rc kernel?

How to contribute to latest -rc kernel?

[Arvid Brodin]

Hi,

How would I go ahead to send a patch for the latest -rc kernel?

Specifically:

* What tree to diff against? (Linus'?)
* To which list do I send the patch?

Background: I've contributed a new network driver that is now in 3.13-rc1. I
would like to fix it so that it behaves better with iproute. Strictly speaking
this isn't a bug fix, but the driver is going to be quite useless without
iproute support, and that won't be there until this fix is in the kernel.


--
Arvid Brodin | Consultant (Linux)
ALTEN | Knarrarn?sgatan 7 | SE-164 40 Kista | Sweden
arvid.brodin at alten.se | www.alten.se/en/
________________________________
Xdin is changing its name. From 25 November 2013 we will be known as Alten. Read more at www.alten.se

How to contribute to latest -rc kernel?

[Aldo Iljazi]

 Arvid Brodin wrote:

> * What tree to diff against? (Linus'?)

I believe that you need to diff against linux-next tree: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/?id=refs/tags/next-20131126

> * To which list do I send the patch?

Well you can send it to the Linux Kernel Mailing List.
-- 
Aldo Iljazi

How to contribute to latest -rc kernel?

[Fan Du]

On 2013?11?26? 05:17, Arvid Brodin wrote:
> Hi,
>
> How would I go ahead to send a patch for the latest -rc kernel?
>
> Specifically:
>
> * What tree to diff against? (Linus'?)
> * To which list do I send the patch?
>
> Background: I've contributed a new network driver that is now in 3.13-rc1. I
> would like to fix it so that it behaves better with iproute. Strictly speaking
> this isn't a bug fix, but the driver is going to be quite useless without
> iproute support, and that won't be there until this fix is in the kernel.

Almost every subsystem has its own next git tree, since it's a networking driver
issue, please verify your fix against net-next:

https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/

And send the patch to netdev maillist:
http://vger.kernel.org/vger-lists.html#netdev

You need also CC the driver maintainer by looking at linux_source_code/MAINTAINERS,
or using ./scripts/get_maintainer.pl.


>
> --
> Arvid Brodin | Consultant (Linux)
> ALTEN | Knarrarn?sgatan 7 | SE-164 40 Kista | Sweden
> arvid.brodin at alten.se | www.alten.se/en/
> ________________________________
> Xdin is changing its name. From 25 November 2013 we will be known as Alten. Read more at www.alten.se
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

-- 
?????????

--fan fan

How to contribute to latest -rc kernel?

[Arvid Brodin]

On 2013-11-27 02:20, Fan Du wrote:
>
>
> On 2013?11?26? 05:17, Arvid Brodin wrote:
>> Hi,
>>
>> How would I go ahead to send a patch for the latest -rc kernel?
>>
>> Specifically:
>>
>> * What tree to diff against? (Linus'?)
>> * To which list do I send the patch?
>>
>> Background: I've contributed a new network driver that is now in 3.13-rc1. I
>> would like to fix it so that it behaves better with iproute. Strictly speaking
>> this isn't a bug fix, but the driver is going to be quite useless without
>> iproute support, and that won't be there until this fix is in the kernel.
>
> Almost every subsystem has its own next git tree, since it's a networking driver
> issue, please verify your fix against net-next:
>
> https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/
>
> And send the patch to netdev maillist:
> http://vger.kernel.org/vger-lists.html#netdev
>
> You need also CC the driver maintainer by looking at linux_source_code/MAINTAINERS,
> or using ./scripts/get_maintainer.pl.
>

Actually, part of the patch series is adding myself as the maintainer for the
driver. :)

I thought the subsystem -next trees was for the next release of Linux? I.e., what
goes into the net-next tree now will find its way into mainline at the next
release window, for linux-3.14-rc1?

I'm not sure though. It's a bit confusing. Aldo Iljazi said this:
>  Arvid Brodin wrote:
>
>> * What tree to diff against? (Linus'?)
>
> I believe that you need to diff against linux-next tree: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/?id=refs/tags/next-20131126
>
>> * To which list do I send the patch?
>
> Well you can send it to the Linux Kernel Mailing List.
> -- Aldo Iljazi

Which seems reasonable to me. Is there anyone who can confirm this?


--
Arvid Brodin | Consultant (Linux)
ALTEN | Knarrarn?sgatan 7 | SE-164 40 Kista | Sweden
arvid.brodin at alten.se | www.alten.se/en/

________________________________
Xdin has changed its name. From 25 November 2013 we are known as Alten. Read more at www.alten.se

How to contribute to latest -rc kernel?

[Fan Du]

On 2013?11?28? 00:26, Arvid Brodin wrote:
> On 2013-11-27 02:20, Fan Du wrote:
>>
>>
>> On 2013?11?26? 05:17, Arvid Brodin wrote:
>>> Hi,
>>>
>>> How would I go ahead to send a patch for the latest -rc kernel?
>>>
>>> Specifically:
>>>
>>> * What tree to diff against? (Linus'?)
>>> * To which list do I send the patch?
>>>
>>> Background: I've contributed a new network driver that is now in 3.13-rc1. I
>>> would like to fix it so that it behaves better with iproute. Strictly speaking
>>> this isn't a bug fix, but the driver is going to be quite useless without
>>> iproute support, and that won't be there until this fix is in the kernel.
>>
>> Almost every subsystem has its own next git tree, since it's a networking driver
>> issue, please verify your fix against net-next:
>>
>> https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/
>>
>> And send the patch to netdev maillist:
>> http://vger.kernel.org/vger-lists.html#netdev
>>
>> You need also CC the driver maintainer by looking at linux_source_code/MAINTAINERS,
>> or using ./scripts/get_maintainer.pl.
>>
>
> Actually, part of the patch series is adding myself as the maintainer for the
> driver. :)

I'm afraid this will depends on your fix is a major one or trivial...

> I thought the subsystem -next trees was for the next release of Linux? I.e., what
> goes into the net-next tree now will find its way into mainline at the next
> release window, for linux-3.14-rc1?
>
> I'm not sure though. It's a bit confusing. Aldo Iljazi said this:
>>   Arvid Brodin wrote:
>>
>>> * What tree to diff against? (Linus'?)
>>
>> I believe that you need to diff against linux-next tree: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/?id=refs/tags/next-20131126
>>
>>> * To which list do I send the patch?
>>
>> Well you can send it to the Linux Kernel Mailing List.
>> -- Aldo Iljazi
>
> Which seems reasonable to me. Is there anyone who can confirm this?

As I said before, if your fix is networking related, please rebase against net-next.
Refer: Documentation/networking/netdev-FAQ.txt


>
> --
> Arvid Brodin | Consultant (Linux)
> ALTEN | Knarrarn?sgatan 7 | SE-164 40 Kista | Sweden
> arvid.brodin at alten.se | www.alten.se/en/
>
> ________________________________
> Xdin has changed its name. From 25 November 2013 we are known as Alten. Read more at www.alten.se
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

-- 
?????????

--fan fan

How to contribute to latest -rc kernel?

[Bjørn Mork]

Arvid Brodin <arvid.brodin@alten.se> writes:

> I thought the subsystem -next trees was for the next release of Linux? I.e., what
> goes into the net-next tree now will find its way into mainline at the next
> release window, for linux-3.14-rc1?

That's correct.

If your series is for the networking subsystem *and* appropriate for an
-rcX where X > 1, then it should be based on

  https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/

and you should indicate that you want it applied to "net" instead of
"net-next".  I usually do that by including "net" in the subject prefix,
like e. g.

 Subject: [PATCH net] foo: fix obvious bug

but there are no strict rules about how to do this AFAIK.

Note that the whole series must be applicable to "net".  Don't be
tempted to mix any features in there.  Split those out in a separate
series instead and submit for "net-next".  If they depend on any of the
changes you made to "net", then explain that dependency in the
cover-letter.

And yes, a cover-letter ("PATCH 0/X") is always a good idea when posting
more than 1 patch in a series. Davem use them as pseudo-merge commits,
so whatever you write there is even recorded in the history.  This is a
good place to explain why the series should be applied to "net" if that
isn't 103% obvious (sometimes you need to know a driver pretty well to
understand why something is a bugfix and not a feature).

I believe all this is explained in more detail in the
Documentation/networking/netdev-FAQ.txt document Fan Du pointed you to.
That's a good place to start.  There are some small differences between
networking and most other subsystems, like comment style and stable
submissions.  There's usually no problem if you miss those details in
the beginning - you'll just have to fix it later.  But reading the FAQ
will give you a head start.


Bj?rn

How to contribute to latest -rc kernel?

[Arvid Brodin]

On 2013-11-28 09:11, Bj?rn Mork wrote:
> Arvid Brodin <arvid.brodin@alten.se> writes:
>
>> I thought the subsystem -next trees was for the next release of Linux? I.e., what
>> goes into the net-next tree now will find its way into mainline at the next
>> release window, for linux-3.14-rc1?
>
> That's correct.
>
> If your series is for the networking subsystem *and* appropriate for an
> -rcX where X > 1, then it should be based on
>
>   https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/
>
> and you should indicate that you want it applied to "net" instead of
> "net-next".  I usually do that by including "net" in the subject prefix,
> like e. g.
>
>  Subject: [PATCH net] foo: fix obvious bug
>
> but there are no strict rules about how to do this AFAIK.
>
> Note that the whole series must be applicable to "net".  Don't be
> tempted to mix any features in there.  Split those out in a separate
> series instead and submit for "net-next".  If they depend on any of the
> changes you made to "net", then explain that dependency in the
> cover-letter.
>
> And yes, a cover-letter ("PATCH 0/X") is always a good idea when posting
> more than 1 patch in a series. Davem use them as pseudo-merge commits,
> so whatever you write there is even recorded in the history.  This is a
> good place to explain why the series should be applied to "net" if that
> isn't 103% obvious (sometimes you need to know a driver pretty well to
> understand why something is a bugfix and not a feature).
>
> I believe all this is explained in more detail in the
> Documentation/networking/netdev-FAQ.txt document Fan Du pointed you to.
> That's a good place to start.  There are some small differences between
> networking and most other subsystems, like comment style and stable
> submissions.  There's usually no problem if you miss those details in
> the beginning - you'll just have to fix it later.  But reading the FAQ
> will give you a head start.
>
>
> Bj?rn
>

Thank you Bj?rn for a great answer!

Thanks also to Fan Du for pointing to the netdev-FAQ.


--
Arvid Brodin | Consultant (Linux)
ALTEN | Knarrarn?sgatan 7 | SE-164 40 Kista | Sweden
arvid.brodin at alten.se | www.alten.se/en/

________________________________
Xdin has changed its name. From 25 November 2013 we are known as Alten. Read more at www.alten.se