From: karthik.188@gmail.com (karthik)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Are Small Changes in kernel accepted as patches
Date: Sat, 21 Jun 2014 20:12:10 +0530 [thread overview]
Message-ID: <53A599C2.5000402@gmail.com> (raw)
In-Reply-To: <26608.1403360621@turing-police.cc.vt.edu>
On Saturday 21 June 2014 07:53 PM, Valdis.Kletnieks at vt.edu wrote:
> On Sat, 21 Jun 2014 15:07:49 +0530, karthik said:
>
>> I was just going through the linux-next source and found a small change
>> in one of the files. (Unnecessary else)
> One-line patches that fix misleading logic are always welcome.
>
> Just remember to:
>
> 1_ Read Documentation/SubmititingPatches.txt and follow the directions
>
> 2) In the patch description/ changelog explain *why* the 'else' is unneeded
> as that's a change in the program logic. And then fix it correctly - if
> the else is unneeded because you can prove it's deal code because the
> if condition is always true, then the 'if then' part can probably be
> fixed up as well....
Brilliant
Thanks for the replies
prev parent reply other threads:[~2014-06-21 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 9:37 Are Small Changes in kernel accepted as patches karthik
2014-06-21 10:04 ` Jeff Kirsher
2014-06-21 10:27 ` Robert P. J. Day
2014-06-21 14:23 ` Valdis.Kletnieks at vt.edu
2014-06-21 14:42 ` karthik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A599C2.5000402@gmail.com \
--to=karthik.188@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).