kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: xerofoify@gmail.com (Nick)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Curious about corner case in btrfs code
Date: Tue, 26 Aug 2014 18:47:41 -0400	[thread overview]
Message-ID: <53FD0E8D.9010407@gmail.com> (raw)

After reading through the code in inode.c today , I am curious about the comment and the following code I will paste
below. I am curious if this corner case is hit often enough for me to write a patch to improve the speed of this 
corner case. Furthermore , compress_file_range is the function name, in case you can't guess by the pasted code.
Regards Nick
411 	/*
412 	 * we don't want to send crud past the end of i_size through
413 	 * compression, that's just a waste of CPU time.  So, if the
414 	 * end of the file is before the start of our current
415 	 * requested range of bytes, we bail out to the uncompressed
416 	 * cleanup code that can deal with all of this.
417 	 *
418 	 * It isn't really the fastest way to fix things, but this is a
419 	 * very uncommon corner.
420 	 */
421 	if (actual_end <= start)
422 		goto cleanup_and_bail_uncompressed;

             reply	other threads:[~2014-08-26 22:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26 22:47 Nick [this message]
2014-08-26 22:58 ` Curious about corner case in btrfs code Mandeep Sandhu
2014-08-26 23:14   ` Nick
2014-08-26 23:36     ` Mandeep Sandhu
2014-08-27  0:05     ` Tobias Boege
2014-08-27  0:13       ` Nick
2014-08-27  0:36         ` Valdis.Kletnieks at vt.edu
2014-08-27  0:37         ` Tobias Boege
2014-08-27  0:41           ` Nick
2014-08-27  1:49         ` Greg Freemyer
2014-08-27  4:08           ` Valdis.Kletnieks at vt.edu
2014-08-27  4:47             ` nick
2014-08-27  5:09               ` Aruna Hewapathirane
2014-08-27 17:35                 ` nick
2014-08-26 23:34 ` Valdis.Kletnieks at vt.edu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FD0E8D.9010407@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).