From: xerofoify@gmail.com (nick)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Bug Patch
Date: Mon, 08 Sep 2014 17:05:39 -0400 [thread overview]
Message-ID: <540E1A23.2040200@gmail.com> (raw)
In-Reply-To: <15552.1410199704@turing-police.cc.vt.edu>
On 14-09-08 02:08 PM, Valdis.Kletnieks at vt.edu wrote:
> On Mon, 08 Sep 2014 06:36:34 -0400, nick said:
>
>> Found a bug and attempted to fix it
>> sub_skb = dev_alloc_skb(nSubframe_Length + 12);
>> + if (!sub_skb)
>> + return -ENOMEM;
>
> Nick - we've told you before to research this stuff more fully before
> posting patches. As others have pointed out, there's exactly one caller, who
> wants a different return on error.
>
> For bonus points - explain why you're returning a -ENOMEM from
> a function that's declared as 'static u8 parse_subframe(...'.
>
> This is *NOT* how you convince us that you should be allowed anywhere near
> kernel code.
>
Fixed the patch, and Valdis thanks for the note about reading the code properly first.
Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-staging-Fix-ieee_80211_rx.c-to-check-for-Null-alloca.patch
Type: text/x-patch
Size: 1145 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140908/4028da71/attachment.bin
next prev parent reply other threads:[~2014-09-08 21:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 10:36 Bug Patch nick
2014-09-08 11:10 ` Sudip Mukherjee
2014-09-08 11:21 ` Tobias S. Josefowitz
2014-09-08 11:35 ` Sudip Mukherjee
2014-09-08 12:45 ` Doug Wilson
2014-09-08 18:08 ` Valdis.Kletnieks at vt.edu
2014-09-08 21:05 ` nick [this message]
2014-09-08 22:09 ` Valdis.Kletnieks at vt.edu
2014-09-09 0:51 ` nick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540E1A23.2040200@gmail.com \
--to=xerofoify@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).