From: xerofoify@gmail.com (nick)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Trial Patch
Date: Tue, 09 Sep 2014 21:21:18 -0400 [thread overview]
Message-ID: <540FA78E.5080400@gmail.com> (raw)
In-Reply-To: <87938.1410300222@turing-police.cc.vt.edu>
On 14-09-09 06:03 PM, Valdis.Kletnieks at vt.edu wrote:
> On Tue, 09 Sep 2014 17:16:19 -0400, nick said:
>
>> I am sending this in again fixed and working.
>
> Typos are still there, and zero explanation of how you verified
> "fixed and working", which given your track record of failing to
> even compile test your code is a *big* show-stopper.
>
> If you don't care about your patch enough to even bother fixing
> the typos, why should anybody else care?
>
>> I also looked at your complain about write_nic_byte and this seems to be
>> there if this succeeds.
>
> OK. This is C 101. How does write_nic_byte() get called if we just did
> the 'return false' and left both the do/while loop and the entire
> function in your patch?
>
Not going to execute, I wasn't sure if that statement needs to be executed.
Seems it needs to be for the driver to be activated. Thanks for helping
out with my sloppiness :) and being patience. If there are any more problems
let me known.
Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-staging-Fix-NULL-check-for-allocating-the-skb-in-r81.patch
Type: text/x-patch
Size: 1479 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140909/b3c63bd9/attachment.bin
next prev parent reply other threads:[~2014-09-10 1:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 3:08 Trial Patch nick
2014-09-09 4:04 ` Valdis.Kletnieks at vt.edu
2014-09-09 12:22 ` nick
2014-09-09 12:42 ` Sudip Mukherjee
2014-09-09 13:24 ` nick
2014-09-09 13:39 ` Sudip Mukherjee
2014-09-09 13:26 ` Valdis.Kletnieks at vt.edu
2014-09-09 13:45 ` Greg Freemyer
2014-09-09 13:54 ` Peter Senna Tschudin
2014-09-09 15:52 ` Nick Krause
2014-09-09 16:40 ` Valdis.Kletnieks at vt.edu
2014-09-09 21:16 ` nick
2014-09-09 21:33 ` Hugo Mills
2014-09-09 22:03 ` Valdis.Kletnieks at vt.edu
2014-09-10 1:21 ` nick [this message]
2014-09-10 2:52 ` Valdis.Kletnieks at vt.edu
2014-09-10 2:56 ` nick
2014-09-10 3:07 ` Valdis.Kletnieks at vt.edu
2014-09-10 3:11 ` nick
2014-09-10 3:53 ` nick
2014-09-10 4:49 ` Valdis.Kletnieks at vt.edu
2014-09-10 11:26 ` nick
2014-09-10 11:36 ` Hugo Mills
2014-09-10 11:38 ` Kristofer Hallin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540FA78E.5080400@gmail.com \
--to=xerofoify@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).