kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: xerofoify@gmail.com (nick)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Trial Patch
Date: Wed, 10 Sep 2014 07:26:32 -0400	[thread overview]
Message-ID: <54103568.4010208@gmail.com> (raw)
In-Reply-To: <111862.1410324557@turing-police.cc.vt.edu>



On 14-09-10 12:49 AM, Valdis.Kletnieks at vt.edu wrote:
> On Tue, 09 Sep 2014 23:53:50 -0400, nick said:
>> Build Error. Fixed it. I need to really check my patches first :(.
> 
> How many times have you done that now?
> 
>> In addition, I want you to forget about and not reply to any patches
>> you known I haven't build tested.
> 
> No, it doesn't work like that.  Each broken post counts against you.
> 
>> +		if (skb == NULL) {
>> +			skb_queue_purge(&priv->rtllib->skb_waitQ[TXCMD_QUEUE]);
>> +			break;
>> +		}
> 
> Like this one - it's *still* wrong.  Because....
> 
> From: Nicholas Krause <xerofoify@gmail.com>
> Date: Tue, 9 Sep 2014 21:12:56 -0400
> 
> You reposted the same broken patch again.
> 
> Please do the Linux kernel community a favor and seek gainful employment
> in the food service industry or similar, where your skills will be more
> appreciated.
> 
Here is the correct patch.
Nick 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-staging-Fix-NULL-check-for-allocating-the-skb-in-r81.patch
Type: text/x-patch
Size: 1481 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140910/a09e101e/attachment.bin 

  reply	other threads:[~2014-09-10 11:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09  3:08 Trial Patch nick
2014-09-09  4:04 ` Valdis.Kletnieks at vt.edu
2014-09-09 12:22 ` nick
2014-09-09 12:42   ` Sudip Mukherjee
2014-09-09 13:24     ` nick
2014-09-09 13:39       ` Sudip Mukherjee
2014-09-09 13:26   ` Valdis.Kletnieks at vt.edu
2014-09-09 13:45 ` Greg Freemyer
2014-09-09 13:54   ` Peter Senna Tschudin
2014-09-09 15:52     ` Nick Krause
2014-09-09 16:40       ` Valdis.Kletnieks at vt.edu
2014-09-09 21:16         ` nick
2014-09-09 21:33           ` Hugo Mills
2014-09-09 22:03           ` Valdis.Kletnieks at vt.edu
2014-09-10  1:21             ` nick
2014-09-10  2:52               ` Valdis.Kletnieks at vt.edu
2014-09-10  2:56                 ` nick
2014-09-10  3:07                   ` Valdis.Kletnieks at vt.edu
2014-09-10  3:11                     ` nick
2014-09-10  3:53                       ` nick
2014-09-10  4:49                         ` Valdis.Kletnieks at vt.edu
2014-09-10 11:26                           ` nick [this message]
2014-09-10 11:36                             ` Hugo Mills
2014-09-10 11:38                             ` Kristofer Hallin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54103568.4010208@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).