From: riel@surriel.com (Rik van Riel)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Checkpatch Patches
Date: Tue, 16 Sep 2014 14:44:46 -0400 [thread overview]
Message-ID: <5418851E.3040104@surriel.com> (raw)
In-Reply-To: <CAAXLKtRVH0tjV2xggk7zvkDUqunzMLL108SyCS_L9zYne+2X+w@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/16/2014 02:36 PM, Kristofer Hallin wrote:
> On Tue, Sep 16, 2014 at 8:29 PM, Nick Krause <xerofoify@gmail.com>
> wrote:
>> On Tue, Sep 16, 2014 at 1:39 PM, <Valdis.Kletnieks@vt.edu>
>> wrote:
>>> On Tue, 16 Sep 2014 13:28:06 -0400, Rik van Riel said:
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>
>>>> On 09/16/2014 01:12 PM, Nick Krause wrote:
>>>>
>>>>> I am going to resend my patch and see if it's good and if
>>>>> not I am going to leave for a while.
>>>>
>>>> You may want to consider fixing them, by applying the advice
>>>> provided by many people, before resending them.
>>>
>>> That's just crazy talk.
>>
>> I am fixing them first and them sending them out. I am going to
>> listen now and only do them correctly. Nick
>
> No, you won't.
Nick,
this is a chance for you to prove the nay-sayers wrong (or right).
When re-posting your patch, you can include information on what tips
you got on how to improve the patch, and how you applied that
information in the new version of the patch.
This is a good idea for anybody resubmitting a changed patch, because
it tells other reviewers what changes were made, why, and who pointed
out the idea for the change.
- --
All rights reversed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJUGIUeAAoJEM553pKExN6DEt8H/36FILPmG4wOK3TZFpQEVJHv
Lxq4DLq7GBUS37PhL/wjdYnLD4RJmOhpGk+FlZBhJ0StnCvS38Su7wwyZTzgCPIS
ir3EYOKhiFgEEuoB4iVaDc2FNv9jKKRVy/QK3jwkdt5oTBvr/I6YZzj2XAFJaUp9
0/RvdSNZU6kcvhTkd5xdDaaX1iOpxrggccRl+Pv2GBapeIEKvO6zk9U2GuLw+r6q
OLfJ5BElpEReoqFJNUXxzT+UyTmMel21REdfyu9UxAEONrQ2A3UHx/7upy71YpyR
a/IADIuBSXTdb31b+uuoFPfSUp4cs7WMyIDK2/tlL8wF28GLoL39X2xhWE3gkUU=
=7mL1
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-09-16 18:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 12:44 Checkpatch Patches nick
2014-09-16 12:47 ` Kristofer Hallin
2014-09-16 12:50 ` nick
2014-09-16 13:06 ` Sudip Mukherjee
2014-09-16 13:11 ` nick
2014-09-16 13:21 ` Sudip Mukherjee
2014-09-16 13:26 ` nick
[not found] ` <CADVatmOZx7q636=b0pQ95CZ93_6jn_jZ2SCPKH7pHmw9P0mRuQ@mail.gmail.com>
[not found] ` <54183C0A.80409@gmail.com>
[not found] ` <CADVatmP1G1pg-vDmn1z-vg9Ppn7Yhvc=hnhbaOyENbdg6WUO2A@mail.gmail.com>
2014-09-16 13:47 ` Sudip Mukherjee
2014-09-16 13:07 ` Robert P. J. Day
2014-09-16 13:13 ` Robert P. J. Day
2014-09-16 14:19 ` Valdis.Kletnieks at vt.edu
2014-09-16 15:44 ` Nick Krause
2014-09-16 15:50 ` Carlo Caione
2014-09-16 15:57 ` Lidza Louina
2014-09-16 16:08 ` Valdis.Kletnieks at vt.edu
2014-09-16 16:14 ` Robert P. J. Day
2014-09-16 16:11 ` Robert P. J. Day
2014-09-16 16:10 ` Hugo Mills
2014-09-16 16:57 ` Sudip Mukherjee
2014-09-16 17:12 ` Nick Krause
2014-09-16 17:27 ` Robert P. J. Day
2014-09-16 17:27 ` Valdis.Kletnieks at vt.edu
2014-09-16 17:28 ` Rik van Riel
2014-09-16 17:39 ` Valdis.Kletnieks at vt.edu
2014-09-16 18:29 ` Nick Krause
2014-09-16 18:36 ` Kristofer Hallin
2014-09-16 18:44 ` Rik van Riel [this message]
2014-09-16 19:30 ` Robert P. J. Day
2014-09-16 18:45 ` Mandeep Sandhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5418851E.3040104@surriel.com \
--to=riel@surriel.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).