kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: xerofoify@gmail.com (nick)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] staging wlan-ng: Add missing blank lines after declarations
Date: Tue, 16 Sep 2014 22:44:25 -0400	[thread overview]
Message-ID: <5418F589.1090404@gmail.com> (raw)
In-Reply-To: <1410921717-16195-1-git-send-email-xerofoify@gmail.com>



On 14-09-16 10:41 PM, Nicholas Krause wrote:
> Fixing trivial checkpatch warnings about missing blank lines after declarations.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 1f2c78c..20d146b 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
>  static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>  {
>  	int result = 0;
> +
>  	result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
>  	if (result == 0)
>  		*((u16 *) val) = le16_to_cpu(*((u16 *) val));
> @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>  static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
>  {
>  	u16 value = cpu_to_le16(val);
> +
>  	return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
>  }
>  
> @@ -1402,6 +1404,7 @@ static inline int
>  hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
>  {
>  	u16 value = cpu_to_le16(val);
> +
>  	return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
>  					    NULL, NULL);
>  }
> 
Greg and others,
Thanks to Amit for checking my grammar firstly. I would like to known before I start cleaning drivers/staging/ and it's subdirectories if this patch is good and valid so I can use it as a template for me to look at when I send out
my other patches.
Thanks and Am So Thankful for all the Chances Here,
Nick 

  reply	other threads:[~2014-09-17  2:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17  2:41 [PATCH] staging wlan-ng: Add missing blank lines after declarations Nicholas Krause
2014-09-17  2:44 ` nick [this message]
2014-09-17  9:52 ` Robert P. J. Day
  -- strict thread matches above, loose matches on Subject: below --
2014-09-16 21:58 Nicholas Krause
2014-09-16 21:59 ` nick
2014-09-17  1:26   ` Amit Agarwal
2014-09-16 21:30 Nicholas Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5418F589.1090404@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).