* [PATCH] staging wlan-ng: Add missing blank lines after declarations
@ 2014-09-17 2:41 Nicholas Krause
2014-09-17 2:44 ` nick
2014-09-17 9:52 ` Robert P. J. Day
0 siblings, 2 replies; 7+ messages in thread
From: Nicholas Krause @ 2014-09-17 2:41 UTC (permalink / raw)
To: kernelnewbies
Fixing trivial checkpatch warnings about missing blank lines after declarations.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 1f2c78c..20d146b 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
{
int result = 0;
+
result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
if (result == 0)
*((u16 *) val) = le16_to_cpu(*((u16 *) val));
@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
{
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
}
@@ -1402,6 +1404,7 @@ static inline int
hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
{
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
NULL, NULL);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] staging wlan-ng: Add missing blank lines after declarations
2014-09-17 2:41 [PATCH] staging wlan-ng: Add missing blank lines after declarations Nicholas Krause
@ 2014-09-17 2:44 ` nick
2014-09-17 9:52 ` Robert P. J. Day
1 sibling, 0 replies; 7+ messages in thread
From: nick @ 2014-09-17 2:44 UTC (permalink / raw)
To: kernelnewbies
On 14-09-16 10:41 PM, Nicholas Krause wrote:
> Fixing trivial checkpatch warnings about missing blank lines after declarations.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 1f2c78c..20d146b 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
> static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
> {
> int result = 0;
> +
> result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
> if (result == 0)
> *((u16 *) val) = le16_to_cpu(*((u16 *) val));
> @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
> static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
> {
> u16 value = cpu_to_le16(val);
> +
> return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
> }
>
> @@ -1402,6 +1404,7 @@ static inline int
> hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
> {
> u16 value = cpu_to_le16(val);
> +
> return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
> NULL, NULL);
> }
>
Greg and others,
Thanks to Amit for checking my grammar firstly. I would like to known before I start cleaning drivers/staging/ and it's subdirectories if this patch is good and valid so I can use it as a template for me to look at when I send out
my other patches.
Thanks and Am So Thankful for all the Chances Here,
Nick
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] staging wlan-ng: Add missing blank lines after declarations
2014-09-17 2:41 [PATCH] staging wlan-ng: Add missing blank lines after declarations Nicholas Krause
2014-09-17 2:44 ` nick
@ 2014-09-17 9:52 ` Robert P. J. Day
1 sibling, 0 replies; 7+ messages in thread
From: Robert P. J. Day @ 2014-09-17 9:52 UTC (permalink / raw)
To: kernelnewbies
On Tue, 16 Sep 2014, Nicholas Krause wrote:
> Fixing trivial checkpatch warnings about missing blank lines after declarations.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
... snip ...
>From Documentation/SubmittingPatches:
"The "summary phrase" may be prefixed by tags enclosed in square
brackets: "Subject: [PATCH tag] <summary phrase>". The tags are not
considered part of the summary phrase, but describe how the patch
should be treated. Common tags might include a version descriptor if
the multiple versions of the patch have been sent out in response to
comments (i.e., "v1, v2, v3") ..."
this is now ... what? version 6? 7? 8? of a patch that adds three
blank lines to a file. so ... still wrong.
didn't you say you were going to leave if you couldn't submit the
next patch properly? whatever happened to that promise?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] staging wlan-ng: Add missing blank lines after declarations
@ 2014-09-16 21:58 Nicholas Krause
2014-09-16 21:59 ` nick
0 siblings, 1 reply; 7+ messages in thread
From: Nicholas Krause @ 2014-09-16 21:58 UTC (permalink / raw)
To: kernelnewbies
Fixing trivial checkpatch warnings about missing blanks lines after declarations.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 1f2c78c..20d146b 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
{
int result = 0;
+
result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
if (result == 0)
*((u16 *) val) = le16_to_cpu(*((u16 *) val));
@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
{
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
}
@@ -1402,6 +1404,7 @@ static inline int
hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
{
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
NULL, NULL);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] staging wlan-ng: Add missing blank lines after declarations
2014-09-16 21:58 Nicholas Krause
@ 2014-09-16 21:59 ` nick
2014-09-17 1:26 ` Amit Agarwal
0 siblings, 1 reply; 7+ messages in thread
From: nick @ 2014-09-16 21:59 UTC (permalink / raw)
To: kernelnewbies
On 14-09-16 05:58 PM, Nicholas Krause wrote:
> Fixing trivial checkpatch warnings about missing blanks lines after declarations.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 1f2c78c..20d146b 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
> static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
> {
> int result = 0;
> +
> result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
> if (result == 0)
> *((u16 *) val) = le16_to_cpu(*((u16 *) val));
> @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
> static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
> {
> u16 value = cpu_to_le16(val);
> +
> return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
> }
>
> @@ -1402,6 +1404,7 @@ static inline int
> hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
> {
> u16 value = cpu_to_le16(val);
> +
> return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
> NULL, NULL);
> }
>
I checked my grammar. I am assuming I am still wrong through.
Nick
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] staging wlan-ng: Add missing blank lines after declarations
2014-09-16 21:59 ` nick
@ 2014-09-17 1:26 ` Amit Agarwal
0 siblings, 0 replies; 7+ messages in thread
From: Amit Agarwal @ 2014-09-17 1:26 UTC (permalink / raw)
To: kernelnewbies
On Tue, 2014-09-16 at 17:59 -0400, nick wrote:
>
> On 14-09-16 05:58 PM, Nicholas Krause wrote:
> > Fixing trivial checkpatch warnings about missing blanks lines after declarations.
> >
"blanks lines after declarations."
> I checked my grammar. I am assuming I am still wrong through.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] staging wlan-ng: Add missing blank lines after declarations
@ 2014-09-16 21:30 Nicholas Krause
0 siblings, 0 replies; 7+ messages in thread
From: Nicholas Krause @ 2014-09-16 21:30 UTC (permalink / raw)
To: kernelnewbies
Fixing trivial checkpatch warnings about missing line after declarations
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 1f2c78c..20d146b 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
{
int result = 0;
+
result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
if (result == 0)
*((u16 *) val) = le16_to_cpu(*((u16 *) val));
@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
{
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
}
@@ -1402,6 +1404,7 @@ static inline int
hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
{
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
NULL, NULL);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-09-17 9:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-17 2:41 [PATCH] staging wlan-ng: Add missing blank lines after declarations Nicholas Krause
2014-09-17 2:44 ` nick
2014-09-17 9:52 ` Robert P. J. Day
-- strict thread matches above, loose matches on Subject: below --
2014-09-16 21:58 Nicholas Krause
2014-09-16 21:59 ` nick
2014-09-17 1:26 ` Amit Agarwal
2014-09-16 21:30 Nicholas Krause
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).